Bug 180016 - [JSC] Remove JSStringBuilder
Summary: [JSC] Remove JSStringBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-26 08:18 PST by Yusuke Suzuki
Modified: 2017-11-26 17:23 PST (History)
11 users (show)

See Also:

Attachments
Patch (19.66 KB, patch)
2017-11-26 08:19 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (19.71 KB, patch)
2017-11-26 08:27 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-11-26 08:18:33 PST 
[JSC] Remove JSStringBuilder
Comment 1 Yusuke Suzuki 2017-11-26 08:19:22 PST 
Created attachment 327583 [details]
Patch
Comment 2 EWS Watchlist 2017-11-26 08:21:03 PST 
Attachment 327583 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/FunctionPrototype.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2017-11-26 08:27:01 PST 
Created attachment 327584 [details]
Patch
Comment 4 Saam Barati 2017-11-26 15:37:13 PST 
Comment on attachment 327584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327584&action=review

> Source/JavaScriptCore/runtime/JSStringInlines.h:50
> +    String result = tryMakeString(string, strings...);

Would it be better to use forwarding semantics here?
Comment 5 Yusuke Suzuki 2017-11-26 17:18:50 PST 
Comment on attachment 327584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327584&action=review

>> Source/JavaScriptCore/runtime/JSStringInlines.h:50
>> +    String result = tryMakeString(string, strings...);
> 
> Would it be better to use forwarding semantics here?

Yeah, good call! Changed :D
Comment 6 Yusuke Suzuki 2017-11-26 17:22:49 PST 
Committed r225150: <https://trac.webkit.org/changeset/225150>
Comment 7 Radar WebKit Bug Importer 2017-11-26 17:23:26 PST 
<rdar://problem/35690851>