Bug 180011 - One too many zeroes in macOS version number in FeatureDefines
Summary: One too many zeroes in macOS version number in FeatureDefines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-25 00:25 PST by Tim Horton
Modified: 2019-12-01 08:42 PST (History)
9 users (show)

See Also:

Attachments
Patch (21.07 KB, patch)
2017-11-25 00:26 PST, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-11-25 00:25:44 PST 
One too many zeroes in macOS version number in FeatureDefines
Comment 1 Tim Horton 2017-11-25 00:26:22 PST 
Created attachment 327573 [details]
Patch
Comment 2 Tim Horton 2017-11-25 00:26:50 PST 
Should be no functional impact, it's just wrong.
Comment 3 EWS Watchlist 2017-11-25 00:29:11 PST 
Attachment 327573 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2017-11-27 09:59:26 PST 
https://trac.webkit.org/changeset/225179/webkit
Comment 5 Radar WebKit Bug Importer 2017-11-27 10:00:31 PST 
<rdar://problem/35700024>
Comment 6 Daniel Bates 2017-12-11 14:59:45 PST 
(In reply to Tim Horton from comment #4)
> https://trac.webkit.org/changeset/225179/webkit

This change broke the WebKit build on macOS Sierra. Committed build fix in <https://trac.webkit.org/changeset/225757/>. For completeness, the build breakage was originally reported in <https://bugs.webkit.org/show_bug.cgi?id=173939#c43>.
Comment 7 Tim Horton 2017-12-11 15:35:09 PST 
(In reply to Daniel Bates from comment #6)
> (In reply to Tim Horton from comment #4)
> > https://trac.webkit.org/changeset/225179/webkit
> 
> This change broke the WebKit build on macOS Sierra. Committed build fix in
> <https://trac.webkit.org/changeset/225757/>. For completeness, the build
> breakage was originally reported in
> <https://bugs.webkit.org/show_bug.cgi?id=173939#c43>.

Weird, wonder why my find and replace fell down. Thank you for fixing!