RESOLVED FIXED Bug 180002
Make reconcileViewportConstrainedLayerPositions start from a specified scrolling node 
https://bugs.webkit.org/show_bug.cgi?id=180002
Summary Make reconcileViewportConstrainedLayerPositions start from a specified scroll...
Frédéric Wang (:fredw)
Reported 2017-11-24 04:21:04 PST
Created attachment 327541 [details] Patch In bug 179946, I'm mentioning that reconcileLayerPositionForViewportRect does not affect children deeper than the root node. Additionally, when the function is called for subframes, the "reconcile layer position" is still only applied from the root node, not the subframe node. The attached patch tries to address that. However, as in bug 179946 I'm not sure about an effect of reconcileLayerPositionForViewportRect that I can test. I tried my patch with the experimental macOS async frame scrolling but still can not see any difference.
Attachments
Patch (9.22 KB, patch)
2017-11-24 04:21 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (applies on top of bugs 173833 and 179946) (12.77 KB, patch)
2018-01-15 09:18 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (7.24 KB, patch)
2018-02-13 23:52 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (12.58 KB, patch)
2018-02-16 06:10 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (6.85 KB, patch)
2018-11-22 06:13 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-01-15 09:18:59 PST
Created attachment 331341 [details] Patch (applies on top of bugs 173833 and 179946) An alternative version applying on top of bugs 173833 and 179946. The test outputs the layer tree. But I'm still not sure how to exhibit a difference with the old code.
Frédéric Wang (:fredw)
Comment 2 2018-02-13 23:52:47 PST
Created attachment 333773 [details] Patch Rebasing
Frédéric Wang (:fredw)
Comment 3 2018-02-16 06:10:31 PST
Created attachment 334038 [details] Patch
Frédéric Wang (:fredw)
Comment 4 2018-11-22 06:13:06 PST
Created attachment 355470 [details] Patch
Frédéric Wang (:fredw)
Comment 5 2018-11-22 06:15:23 PST
@Simon: Can you please take a look at this patch?
WebKit Commit Bot
Comment 6 2018-11-29 13:22:11 PST
Comment on attachment 355470 [details] Patch Clearing flags on attachment: 355470 Committed r238690: <https://trac.webkit.org/changeset/238690>
WebKit Commit Bot
Comment 7 2018-11-29 13:22:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-29 13:23:36 PST
<rdar://problem/46352107>
Note You need to log in before you can comment on or make changes to this bug.