Bug 180002 - Make reconcileViewportConstrainedLayerPositions start from a specified scrolling node
Summary: Make reconcileViewportConstrainedLayerPositions start from a specified scroll...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on: 182868
Blocks: 149264 171667
  Show dependency tree / graph
 
Reported: 2017-11-24 04:21 PST by Frédéric Wang (:fredw)
Modified: 2018-11-29 13:23 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.22 KB, patch)
2017-11-24 04:21 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (applies on top of bugs 173833 and 179946) (12.77 KB, patch)
2018-01-15 09:18 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2018-02-13 23:52 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (12.58 KB, patch)
2018-02-16 06:10 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (6.85 KB, patch)
2018-11-22 06:13 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-11-24 04:21:04 PST 
Created attachment 327541 [details]
Patch

In bug 179946, I'm mentioning that reconcileLayerPositionForViewportRect does not affect children deeper than the root node. Additionally, when the function is called for subframes, the "reconcile layer position" is still only applied from the root node, not the subframe node.

The attached patch tries to address that. However, as in bug 179946 I'm not sure about an effect of reconcileLayerPositionForViewportRect that I can test. I tried my patch with the experimental macOS async frame scrolling but still can not see any difference.
Comment 1 Frédéric Wang (:fredw) 2018-01-15 09:18:59 PST 
Created attachment 331341 [details]
Patch (applies on top of bugs 173833 and 179946)

An alternative version applying on top of bugs 173833 and 179946. The test outputs the layer tree. But I'm still not sure how to exhibit a difference with the old code.
Comment 2 Frédéric Wang (:fredw) 2018-02-13 23:52:47 PST 
Created attachment 333773 [details]
Patch

Rebasing
Comment 3 Frédéric Wang (:fredw) 2018-02-16 06:10:31 PST 
Created attachment 334038 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2018-11-22 06:13:06 PST 
Created attachment 355470 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2018-11-22 06:15:23 PST 
@Simon: Can you please take a look at this patch?
Comment 6 WebKit Commit Bot 2018-11-29 13:22:11 PST 
Comment on attachment 355470 [details]
Patch

Clearing flags on attachment: 355470

Committed r238690: <https://trac.webkit.org/changeset/238690>
Comment 7 WebKit Commit Bot 2018-11-29 13:22:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-29 13:23:36 PST 
<rdar://problem/46352107>