RESOLVED FIXED 179999
WebDriver: add support for accept/dismiss and notify unhandled prompt behavior 
https://bugs.webkit.org/show_bug.cgi?id=179999
Summary WebDriver: add support for accept/dismiss and notify unhandled prompt behavior
Carlos Garcia Campos
Reported 2017-11-24 01:15:16 PST
Those didn't exist when I implemented this. See https://w3c.github.io/webdriver/webdriver-spec.html#dfn-known-prompt-handling-approaches-table
Attachments
Patch (7.04 KB, patch)
2017-11-24 01:21 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Rebased patch (7.01 KB, patch)
2017-12-02 07:15 PST, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-11-24 01:21:31 PST
Created attachment 327530 [details] Patch This won't apply since it depends on patch attached to bug #179979
Carlos Garcia Campos
Comment 2 2017-12-02 07:15:08 PST
Created attachment 328230 [details] Rebased patch
EWS Watchlist
Comment 3 2017-12-02 07:18:21 PST
Attachment 328230 [details] did not pass style-queue: ERROR: Source/WebDriver/Session.h:126: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:127: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:212: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:225: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 4 2017-12-15 05:14:44 PST
Committed r225970: <https://trac.webkit.org/changeset/225970>
Radar WebKit Bug Importer
Comment 5 2017-12-15 05:15:48 PST
<rdar://problem/36072299>
Note You need to log in before you can comment on or make changes to this bug.