RESOLVED FIXED179970
[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations 
https://bugs.webkit.org/show_bug.cgi?id=179970
Summary [CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
Zan Dobersek
Reported 2017-11-23 02:21:07 PST
[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
Attachments
Patch (8.65 KB, patch)
2017-11-23 02:36 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-11-23 02:36:07 PST
Created attachment 327490 [details] Patch
Carlos Garcia Campos
Comment 2 2017-11-23 02:54:30 PST
Comment on attachment 327490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review Yes! > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114 > + { > + GraphicsContext& context = m_buffer->context(); > + context.save(); > + context.clip(rect); > + context.drawImage(*m_image, rect, rect); > + context.restore(); > + } Why do we need another scope? > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:92 > + } Ditto.
Zan Dobersek
Comment 3 2017-11-23 02:59:09 PST
Comment on attachment 327490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114 >> + } > > Why do we need another scope? Just for clarity, to limit the GraphicsContext reference and operations on it to a single block.
Zan Dobersek
Comment 4 2017-11-23 03:04:08 PST
Comment on attachment 327490 [details] Patch Clearing flags on attachment: 327490 Committed r225113: <https://trac.webkit.org/changeset/225113>
Zan Dobersek
Comment 5 2017-11-23 03:04:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-23 03:05:20 PST
<rdar://problem/35674932>
Note You need to log in before you can comment on or make changes to this bug.