Bug 179970 - [CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
Summary: [CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-23 02:21 PST by Zan Dobersek
Modified: 2017-11-23 03:05 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.65 KB, patch)
2017-11-23 02:36 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-11-23 02:21:07 PST 
[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
Comment 1 Zan Dobersek 2017-11-23 02:36:07 PST 
Created attachment 327490 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-11-23 02:54:30 PST 
Comment on attachment 327490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review

Yes!

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114
> +    {
> +        GraphicsContext& context = m_buffer->context();
> +        context.save();
> +        context.clip(rect);
> +        context.drawImage(*m_image, rect, rect);
> +        context.restore();
> +    }

Why do we need another scope?

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:92
> +    }

Ditto.
Comment 3 Zan Dobersek 2017-11-23 02:59:09 PST 
Comment on attachment 327490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:114
>> +    }
> 
> Why do we need another scope?

Just for clarity, to limit the GraphicsContext reference and operations on it to a single block.
Comment 4 Zan Dobersek 2017-11-23 03:04:08 PST 
Comment on attachment 327490 [details]
Patch

Clearing flags on attachment: 327490

Committed r225113: <https://trac.webkit.org/changeset/225113>
Comment 5 Zan Dobersek 2017-11-23 03:04:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-23 03:05:20 PST 
<rdar://problem/35674932>