Bug 179966 - Minor ArrayBufferView cleanup
Summary: Minor ArrayBufferView cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-22 23:26 PST by Simon Fraser (smfr)
Modified: 2017-11-23 14:24 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.70 KB, patch)
2017-11-22 23:29 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-11-22 23:26:55 PST 
Minor ArrayBufferView cleanup
Comment 1 Simon Fraser (smfr) 2017-11-22 23:29:14 PST 
Created attachment 327484 [details]
Patch
Comment 2 Darin Adler 2017-11-23 14:04:07 PST 
Comment on attachment 327484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327484&action=review

> Source/JavaScriptCore/runtime/ArrayBufferView.h:194
> +    // Do not replace with RELEASE_ASSERT; we want to avoid the virtual byteLength() function call in release.

This shows that using the style checker to suggest replacing every last ASSERT_WITH_SECURITY_IMPLICATION with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION might not be the right thing to do.
Comment 3 WebKit Commit Bot 2017-11-23 14:23:18 PST 
Comment on attachment 327484 [details]
Patch

Clearing flags on attachment: 327484

Committed r225123: <https://trac.webkit.org/changeset/225123>
Comment 4 WebKit Commit Bot 2017-11-23 14:23:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-23 14:24:25 PST 
<rdar://problem/35678187>