RESOLVED FIXED Bug 179966
Minor ArrayBufferView cleanup 
https://bugs.webkit.org/show_bug.cgi?id=179966
Summary Minor ArrayBufferView cleanup
Simon Fraser (smfr)
Reported 2017-11-22 23:26:55 PST
Minor ArrayBufferView cleanup
Attachments
Patch (4.70 KB, patch)
2017-11-22 23:29 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-11-22 23:29:14 PST
Created attachment 327484 [details] Patch
Darin Adler
Comment 2 2017-11-23 14:04:07 PST
Comment on attachment 327484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327484&action=review > Source/JavaScriptCore/runtime/ArrayBufferView.h:194 > + // Do not replace with RELEASE_ASSERT; we want to avoid the virtual byteLength() function call in release. This shows that using the style checker to suggest replacing every last ASSERT_WITH_SECURITY_IMPLICATION with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION might not be the right thing to do.
WebKit Commit Bot
Comment 3 2017-11-23 14:23:18 PST
Comment on attachment 327484 [details] Patch Clearing flags on attachment: 327484 Committed r225123: <https://trac.webkit.org/changeset/225123>
WebKit Commit Bot
Comment 4 2017-11-23 14:23:20 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-23 14:24:25 PST
<rdar://problem/35678187>
Note You need to log in before you can comment on or make changes to this bug.