Bug 179965 - WebSWServerConnection should register/unregister itself with the StorageProcess
Summary: WebSWServerConnection should register/unregister itself with the StorageProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-22 22:25 PST by Chris Dumez
Modified: 2017-11-23 09:52 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2017-11-22 22:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2017-11-22 22:42 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-22 22:25:05 PST 
WebSWServerConnection should register/unregister itself with the StorageProcess instead of relying on StorageToWebProcessConnection to do so on its behalf. This is less error-prone.
Comment 1 Chris Dumez 2017-11-22 22:26:12 PST 
Created attachment 327482 [details]
Patch
Comment 2 Chris Dumez 2017-11-22 22:42:38 PST 
Created attachment 327483 [details]
Patch
Comment 3 Darin Adler 2017-11-23 09:31:23 PST 
Comment on attachment 327483 [details]
Patch

Looks good. I noticed that we delete the copy constructor but not the assignment operator from WebSWServerConnection; not sure if that’s good. I don’t absolutely love WTF_MAKE_NONCOPYABLE, but one of its benefits is that it deletes both. By the way, I just noticed that the "private:" in Noncopyable.h is no longer needed, now that we use "delete". I should remove that since it would make the macro easier to use.
Comment 4 WebKit Commit Bot 2017-11-23 09:51:50 PST 
Comment on attachment 327483 [details]
Patch

Clearing flags on attachment: 327483

Committed r225118: <https://trac.webkit.org/changeset/225118>
Comment 5 WebKit Commit Bot 2017-11-23 09:51:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-23 09:52:25 PST 
<rdar://problem/35677379>