Bug 179961 – Web Inspector: Styles Redesign: selector's field shadow is clipped at the bottom

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 327474 [details]
[Image] Bug

When the first property has a warning.

[Nikita Vasilyev]

Created attachment 327475 [details]
Patch

[Nikita Vasilyev]

Created attachment 327476 [details]
[Image] With patch applied

[Matt Baker]

Comment on attachment 327475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327475&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:85
> +    z-index: 1;

What about using one of the --z-index-* variables, like --z-index-highlight?

[Nikita Vasilyev]

(In reply to Matt Baker from comment #3)
> Comment on attachment 327475 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327475&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:85
> > +    z-index: 1;
> 
> What about using one of the --z-index-* variables, like --z-index-highlight?

In my patch, I'm setting z-index on the selector field, not the highlighted property.

I don't think any of the existing --z-index-* variables make sense here, and I think adding a new one just for this is overkill.

[Matt Baker]

Comment on attachment 327475 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 327475 [details]
Patch

Clearing flags on attachment: 327475

Committed r225165: <https://trac.webkit.org/changeset/225165>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35896605>