Bug 179961 - Web Inspector: Styles Redesign: selector's field shadow is clipped at the bottom
Summary: Web Inspector: Styles Redesign: selector's field shadow is clipped at the bottom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-22 17:23 PST by Nikita Vasilyev
Modified: 2017-12-06 16:47 PST (History)
4 users (show)

See Also:


Attachments
[Image] Bug (6.08 KB, image/png)
2017-11-22 17:23 PST, Nikita Vasilyev
no flags Details
Patch (1.19 KB, patch)
2017-11-22 17:25 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (7.00 KB, image/png)
2017-11-22 17:27 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-11-22 17:23:22 PST
Created attachment 327474 [details]
[Image] Bug

When the first property has a warning.
Comment 1 Nikita Vasilyev 2017-11-22 17:25:54 PST
Created attachment 327475 [details]
Patch
Comment 2 Nikita Vasilyev 2017-11-22 17:27:00 PST
Created attachment 327476 [details]
[Image] With patch applied
Comment 3 Matt Baker 2017-11-23 12:02:33 PST
Comment on attachment 327475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327475&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:85
> +    z-index: 1;

What about using one of the --z-index-* variables, like --z-index-highlight?
Comment 4 Nikita Vasilyev 2017-11-25 16:11:02 PST
(In reply to Matt Baker from comment #3)
> Comment on attachment 327475 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327475&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:85
> > +    z-index: 1;
> 
> What about using one of the --z-index-* variables, like --z-index-highlight?

In my patch, I'm setting z-index on the selector field, not the highlighted property.

I don't think any of the existing --z-index-* variables make sense here, and I think adding a new one just for this is overkill.
Comment 5 Matt Baker 2017-11-27 02:43:18 PST
Comment on attachment 327475 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-11-27 03:02:35 PST
Comment on attachment 327475 [details]
Patch

Clearing flags on attachment: 327475

Committed r225165: <https://trac.webkit.org/changeset/225165>
Comment 7 WebKit Commit Bot 2017-11-27 03:02:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-06 16:47:44 PST
<rdar://problem/35896605>