Bug 179960 - [WinCairo] WebPreferences IDL not regenerating
Summary: [WinCairo] WebPreferences IDL not regenerating
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-22 17:15 PST by Don Olmstead
Modified: 2017-11-24 11:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2017-11-23 18:52 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-11-22 17:15:46 PST 
There were issues when landing https://bugs.webkit.org/show_bug.cgi?id=179385 which point to the generated WebPreferences getting stale. This should be resolved to allow WinCairo to build after changes to the preferences.

..\..\Source\WebKitLegacy\win\WebView.cpp(5246): error C2039: 'visualViewportAPIEnabled': is not a member of 'IWebPreferencesPrivate6'

See https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/8578/steps/compile-webkit/logs/stdio
Comment 1 Fujii Hironori 2017-11-22 18:05:37 PST 
Looks like a similar issue with:
  Bug 173352 – [Win] WebKit shouldn't include the forwarding header of WebKit itself
Comment 2 Fujii Hironori 2017-11-23 18:52:21 PST 
Created attachment 327518 [details]
Patch
Comment 3 WebKit Commit Bot 2017-11-24 11:52:58 PST 
Comment on attachment 327518 [details]
Patch

Clearing flags on attachment: 327518

Committed r225139: <https://trac.webkit.org/changeset/225139>
Comment 4 WebKit Commit Bot 2017-11-24 11:53:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-24 11:53:26 PST 
<rdar://problem/35684422>