Bug 179940 - WebDriver: add timeout option to run-webdriver-tests script
Summary: WebDriver: add timeout option to run-webdriver-tests script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-22 03:49 PST by Carlos Garcia Campos
Modified: 2017-11-28 04:46 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.40 KB, patch)
2017-11-22 03:55 PST, Carlos Garcia Campos 		clopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-22 03:49:55 PST 
We need to support timeouts to be able to run the tests in the bots.
Comment 1 Carlos Garcia Campos 2017-11-22 03:55:31 PST 
Created attachment 327449 [details]
Patch
Comment 2 EWS Watchlist 2017-11-22 03:58:07 PST 
Attachment 327449 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:44:  No name 'pytest_timeout' in module 'webkitpy.thirdparty.autoinstalled'  [pylint/E0611] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:141:  [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'do_wdspec' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:141:  [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2017-11-28 04:45:38 PST 
Committed r225211: <https://trac.webkit.org/changeset/225211>
Comment 4 Radar WebKit Bug Importer 2017-11-28 04:46:31 PST 
<rdar://problem/35720714>