Bug 179923 - [JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
Summary: [JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-21 08:49 PST by Yusuke Suzuki
Modified: 2017-11-24 03:05 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.58 KB, patch)
2017-11-21 08:50 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (9.85 KB, patch)
2017-11-21 09:06 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-11-21 08:49:29 PST 
[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
Comment 1 Yusuke Suzuki 2017-11-21 08:50:54 PST 
Created attachment 327413 [details]
Patch
Comment 2 Yusuke Suzuki 2017-11-21 08:52:29 PST 
Comment on attachment 327413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327413&action=review

> Source/JavaScriptCore/runtime/HashMapImpl.h:598
> +        ASSERT(!newEntry->deleted());

This ensures that added key is always non empty.
Comment 3 Yusuke Suzuki 2017-11-21 09:06:24 PST 
Created attachment 327415 [details]
Patch
Comment 4 Yusuke Suzuki 2017-11-24 02:44:07 PST 
Comment on attachment 327415 [details]
Patch

Thank you!
Comment 5 WebKit Commit Bot 2017-11-24 03:04:43 PST 
Comment on attachment 327415 [details]
Patch

Clearing flags on attachment: 327415

Committed r225130: <https://trac.webkit.org/changeset/225130>
Comment 6 WebKit Commit Bot 2017-11-24 03:04:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-24 03:05:25 PST 
<rdar://problem/35682010>