Bug 179908 - [WinCairo] Enable WebP support
Summary: [WinCairo] Enable WebP support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on: 170594
Blocks:
  Show dependency tree / graph
 
Reported: 2017-11-20 19:50 PST by Don Olmstead
Modified: 2023-04-19 01:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.08 KB, patch)
2017-11-20 19:54 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (981 bytes, patch)
2017-12-12 13:41 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (982 bytes, patch)
2017-12-12 14:11 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-11-20 19:50:44 PST 
WinCairoRequirements is building WebP. Now it just needs to be enabled.
Comment 1 Don Olmstead 2017-11-20 19:51:58 PST 
Currently blocked on enabling due to WebKit using /MT instead of /MD
Comment 2 Don Olmstead 2017-11-20 19:54:38 PST 
Created attachment 327384 [details]
Patch
Comment 3 Don Olmstead 2017-11-20 19:55:35 PST 
Comment on attachment 327384 [details]
Patch

Will only commit after the dependent bug is landed.
Comment 4 Konstantin Tokarev 2017-11-21 13:33:01 PST 
It might make sense to have WebP as optional dependency, as it is not really essential for Web
Comment 5 Don Olmstead 2017-11-21 13:36:49 PST 
(In reply to Konstantin Tokarev from comment #4)
> It might make sense to have WebP as optional dependency, as it is not really
> essential for Web

Its being distributed in the updated WinCairoRequirements. Also GTK/WPE have it as REQUIRED as well.
Comment 6 Alex Christensen 2017-11-27 09:22:42 PST 
Is there a specific reason why WebP is needed?  Do you have content that requires it?
Comment 7 Don Olmstead 2017-12-12 13:41:45 PST 
Created attachment 329149 [details]
Patch

Add webp but make it optional
Comment 8 EWS Watchlist 2017-12-12 13:43:40 PST 
Attachment 329149 [details] did not pass style-queue:


ERROR: Source/cmake/OptionsWinCairo.cmake:18:  One space between command "endif" and its parentheses, should be "endif ("  [whitespace/parentheses] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Don Olmstead 2017-12-12 14:11:20 PST 
Created attachment 329153 [details]
Patch
Comment 10 WebKit Commit Bot 2017-12-12 15:41:29 PST 
Comment on attachment 329153 [details]
Patch

Clearing flags on attachment: 329153

Committed r225817: <https://trac.webkit.org/changeset/225817>
Comment 11 WebKit Commit Bot 2017-12-12 15:41:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-12-12 15:42:23 PST 
<rdar://problem/36007096>