Support operations like "&&" and "||" with BigInt.
Created attachment 352488 [details] WIP - Patch
Created attachment 352527 [details] WIP - Patch
*** Bug 186231 has been marked as a duplicate of this bug. ***
*** Bug 186230 has been marked as a duplicate of this bug. ***
*** Bug 182215 has been marked as a duplicate of this bug. ***
Created attachment 353670 [details] Patch
Created attachment 354236 [details] WIP - Patch
Comment on attachment 354236 [details] WIP - Patch Attachment 354236 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9909202 New failing tests: http/wpt/css/css-animations/start-animation-001.html
Created attachment 354240 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 354714 [details] Patch
Created attachment 354812 [details] Patch
Created attachment 355244 [details] Patch
Created attachment 355634 [details] Patch
Created attachment 355865 [details] Patch
Ping Review
Comment on attachment 355865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355865&action=review r=me with nits. > Source/JavaScriptCore/runtime/JSBigInt.cpp:1680 > +bool JSBigInt::toBoolean() const > +{ > + return !isZero(); > +} This function is very very small. I think we should define `isZero` and `toBoolean` as inline functions in JSBigInt.h (inside the class JSBigInt definition).
Created attachment 356431 [details] Patch
Attachment 356431 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSBigInt.h:202: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 356431 [details] Patch Thank you very much for the review!
The commit-queue encountered the following flaky tests while processing attachment 356431 [details]: webgl/2.0.0/conformance/more/functions/copyTexImage2D.html bug 192343 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 356431 [details] Patch Clearing flags on attachment: 356431 Committed r238833: <https://trac.webkit.org/changeset/238833>
All reviewed patches have been landed. Closing bug.
<rdar://problem/46438082>
As EWS indicated in https://webkit-queues.webkit.org/results/10255942, this change broke macOS Debug builds: ERROR: JavaScriptCore has a weak external symbol in it (/Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZNK3JSC8JSBigInt9toBooleanEv
Reverted r238833 for reason: Breaks macOS and iOS debug builds. Committed r238835: <https://trac.webkit.org/changeset/238835>
Created attachment 356482 [details] Patch
Attachment 356482 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSBigInt.h:202: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 356482 [details] Patch Attachment 356482 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10262081 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html
Created attachment 356490 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #28) > Comment on attachment 356482 [details] > Patch > > Attachment 356482 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/10262081 > > New failing tests: > http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html Regression not related with this Patch.
Comment on attachment 356482 [details] Patch Clearing flags on attachment: 356482 Committed r238861: <https://trac.webkit.org/changeset/238861>