[Cairo] drawNativeImage(), drawPattern() in CairoOperations should operate directly with cairo_surface_t objects
Created attachment 327365 [details] Patch
Comment on attachment 327365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327365&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.h:96 > -void drawGlyphs(GraphicsContext&, const GraphicsContextState&, bool, const FloatPoint&, cairo_scaled_font_t*, double, const Vector<cairo_glyph_t>&, float, GraphicsContext&); > +void drawGlyphs(PlatformContextCairo&, const GraphicsContextState&, const FloatPoint&, cairo_scaled_font_t*, double, const Vector<cairo_glyph_t>&, float, GraphicsContext&); Is this related to this change? I'm surprised it builds.
Comment on attachment 327365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327365&action=review >> Source/WebCore/platform/graphics/cairo/CairoOperations.h:96 >> +void drawGlyphs(PlatformContextCairo&, const GraphicsContextState&, const FloatPoint&, cairo_scaled_font_t*, double, const Vector<cairo_glyph_t>&, float, GraphicsContext&); > > Is this related to this change? I'm surprised it builds. It's not directly related, just an opportunistic fix. It still builds because of the unified sources build. As it stands, there are essentially two drawGlyphs() overloads, but this one isn't defined, which isn't a problem because it doesn't get used. But because the CairoOperations.cpp file is included in the single unified source .cpp file before GraphicsContextCairo.cpp, the correct drawGlyphs() function is properly defined, and the build doesn't break.
Comment on attachment 327365 [details] Patch Clearing flags on attachment: 327365 Committed r225077: <https://trac.webkit.org/changeset/225077>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35656656>