Bug 179871 - Remove slow repaint object from FrameView when style changes.
Summary: Remove slow repaint object from FrameView when style changes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-18 21:19 PST by zalan
Modified: 2017-11-20 09:19 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.86 KB, patch)
2017-11-19 18:34 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-11-18 21:19:31 PST 
rdar://problem/34949171
Comment 1 zalan 2017-11-19 18:34:45 PST 
Created attachment 327353 [details]
Patch
Comment 2 zalan 2017-11-19 18:35:46 PST 
Comment on attachment 327353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327353&action=review

> Source/WebCore/rendering/RenderElement.cpp:921
> +        if (drawsRootBackground && newStyle.hasEntirelyFixedBackground() && view().compositor().supportsFixedRootBackgroundCompositing())
> +            newStyleSlowScroll = false;

or simply newStyleSlowScroll = !((drawsRootBackground && newStyle.hasEntirelyFixedBackground() && view().compositor().supportsFixedRootBackgroundCompositing()));
Comment 3 WebKit Commit Bot 2017-11-20 09:19:00 PST 
Comment on attachment 327353 [details]
Patch

Clearing flags on attachment: 327353

Committed r225052: <https://trac.webkit.org/changeset/225052>
Comment 4 WebKit Commit Bot 2017-11-20 09:19:02 PST 
All reviewed patches have been landed.  Closing bug.