Bug 179868 - Mechanical cleanup of FE* files
Summary: Mechanical cleanup of FE* files
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2017-11-18 16:57 PST by Simon Fraser (smfr)
Modified: 2017-11-18 17:56 PST (History)
4 users (show)

See Also:

Patch (63.77 KB, patch)
2017-11-18 16:59 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-11-18 16:57:23 PST
Mechanical cleanup of FE* files
Comment 1 Simon Fraser (smfr) 2017-11-18 16:59:31 PST
Created attachment 327327 [details]
Comment 2 Wenson Hsieh 2017-11-18 17:09:59 PST
Comment on attachment 327327 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=327327&action=review


> Source/WebCore/platform/graphics/filters/FEColorMatrix.h:44
>      bool setType(ColorMatrixType);

This seems straightforward enough that we could just inline it alongside the getter above.

> Source/WebCore/platform/graphics/filters/FEColorMatrix.h:55
> +    void platformApplySoftware() override;

Is FEColorMatrix something we might want to subclass? If not, we should consider just making this final.

> Source/WebCore/platform/graphics/filters/FEColorMatrix.h:57
> +    WTF::TextStream& externalRepresentation(WTF::TextStream&, int indention) const override;

Comment 3 WebKit Commit Bot 2017-11-18 17:55:41 PST
Comment on attachment 327327 [details]

Clearing flags on attachment: 327327

Committed r225026: <https://trac.webkit.org/changeset/225026>
Comment 4 WebKit Commit Bot 2017-11-18 17:55:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-18 17:56:19 PST