Bug 179864 - filter-build-webkit filters out useful compiler error lines
Summary: filter-build-webkit filters out useful compiler error lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-18 13:03 PST by Simon Fraser (smfr)
Modified: 2018-01-03 16:43 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.12 KB, patch)
2017-12-20 14:52 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (1.96 KB, patch)
2018-01-03 11:48 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-11-18 13:03:06 PST 
filter-build-webkit turns this:

In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1:
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing]
        std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue
        std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        static_cast<float>(                                                              )


into this:

In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1:
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        static_cast<float>(                                                              )

which hides some detail needed to fix bugs.
Comment 1 Simon Fraser (smfr) 2017-12-20 14:52:06 PST 
Created attachment 329955 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-01-03 11:48:55 PST 
Created attachment 330405 [details]
Patch
Comment 3 WebKit Commit Bot 2018-01-03 16:42:24 PST 
Comment on attachment 330405 [details]
Patch

Clearing flags on attachment: 330405

Committed r226378: <https://trac.webkit.org/changeset/226378>
Comment 4 WebKit Commit Bot 2018-01-03 16:42:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-03 16:43:24 PST 
<rdar://problem/36287675>