Bug 179859 - [WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
Summary: [WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-18 05:36 PST by Yusuke Suzuki
Modified: 2017-11-18 06:11 PST (History)
15 users (show)

See Also:

Attachments
Patch (5.57 KB, patch)
2017-11-18 05:39 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (5.93 KB, patch)
2017-11-18 06:02 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (5.93 KB, patch)
2017-11-18 06:05 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-11-18 05:36:45 PST 
[WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
Comment 1 Yusuke Suzuki 2017-11-18 05:39:59 PST 
Created attachment 327309 [details]
Patch
Comment 2 JF Bastien 2017-11-18 05:50:27 PST 
Comment on attachment 327309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327309&action=review

> Source/WTF/wtf/StackBounds.cpp:61
> +        result = testStackDirection(nullptr);

I don’t think nullptr is valid here.

> Source/WTF/wtf/StackBounds.cpp:65
> +

Seems like we can hardcode direction for known cpus here so they constant food away.
Comment 3 Yusuke Suzuki 2017-11-18 05:52:47 PST 
Comment on attachment 327309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327309&action=review

>> Source/WTF/wtf/StackBounds.cpp:61
>> +        result = testStackDirection(nullptr);
> 
> I don’t think nullptr is valid here.

I'll split this function to offer stack pointer to this function.

>> Source/WTF/wtf/StackBounds.cpp:65
>> +
> 
> Seems like we can hardcode direction for known cpus here so they constant food away.

I'll do this for major CPUs.
Comment 4 Yusuke Suzuki 2017-11-18 06:02:55 PST 
Created attachment 327310 [details]
Patch
Comment 5 JF Bastien 2017-11-18 06:05:31 PST 
Comment on attachment 327310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review

r=me with bugfix

> Source/WTF/wtf/StackBounds.cpp:72
> +        result = testStackDirection(nullptr);

That won’t compile with nullptr :)
Comment 6 Yusuke Suzuki 2017-11-18 06:05:52 PST 
Created attachment 327311 [details]
Patch
Comment 7 Yusuke Suzuki 2017-11-18 06:06:37 PST 
Comment on attachment 327310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review

>> Source/WTF/wtf/StackBounds.cpp:72
>> +        result = testStackDirection(nullptr);
> 
> That won’t compile with nullptr :)

Oops. Thanks. Fixed.
Comment 8 Yusuke Suzuki 2017-11-18 06:10:05 PST 
Committed r225015: <https://trac.webkit.org/changeset/225015>
Comment 9 Radar WebKit Bug Importer 2017-11-18 06:11:34 PST 
<rdar://problem/35631948>