Bug 179856 - Rebaseline and/or turn on more iOS selection tests that either already pass, or need minimal visual tweaking
Summary: Rebaseline and/or turn on more iOS selection tests that either already pass, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 17:48 PST by Megan Gardner
Modified: 2017-11-27 13:47 PST (History)
7 users (show)

See Also:

Attachments
Patch (302.96 KB, patch)
2017-11-17 17:50 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-11-17 17:48:12 PST 
Rebaseline and/or turn on more iOS selection tests that either already pass, or need minimal visual tweaking
Comment 1 Megan Gardner 2017-11-17 17:50:43 PST 
Created attachment 327290 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-11-17 17:52:18 PST 
<rdar://problem/35628267>
Comment 3 Myles C. Maxfield 2017-11-17 22:12:44 PST 
Comment on attachment 327290 [details]
Patch

In the future you don't need reviews for test gardening.
Comment 4 WebKit Commit Bot 2017-11-17 22:32:27 PST 
Comment on attachment 327290 [details]
Patch

Clearing flags on attachment: 327290

Committed r225013: <https://trac.webkit.org/changeset/225013>
Comment 5 WebKit Commit Bot 2017-11-17 22:32:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Megan Gardner 2017-11-27 13:40:45 PST 
Thanks for the review! Since I haven't done much gardening, Tim wanted me to get my first couple reviewed, this was going to be my last one :) 
(In reply to Myles C. Maxfield from comment #3)
> Comment on attachment 327290 [details]
> Patch
> 
> In the future you don't need reviews for test gardening.
Comment 7 Tim Horton 2017-11-27 13:47:08 PST 
You’re free!