Bug 179853 - [mac-wk1] LayoutTest imported/blink/fast/text/international-iteration-simple-text.html is a flaky failure
Summary: [mac-wk1] LayoutTest imported/blink/fast/text/international-iteration-simple-...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 188441 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-17 17:00 PST by Ryan Haddad
Modified: 2022-04-23 19:19 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-11-17 17:00:56 PST
LayoutTest imported/blink/fast/text/international-iteration-simple-text.html is failing

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224985%20(4913)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fblink%2Ffast%2Ftext%2Finternational-iteration-simple-text.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/imported/blink/fast/text/international-iteration-simple-text-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/imported/blink/fast/text/international-iteration-simple-text-actual.txt
@@ -1 +1,3 @@
 Test passes if it does not crash.
+
+
Comment 1 Ryan Haddad 2017-11-17 17:01:24 PST
This appears to be limited to Mac-wk1.
Comment 2 Radar WebKit Bug Importer 2017-11-21 06:46:38 PST
<rdar://problem/35657395>
Comment 3 Ryan Haddad 2018-01-26 17:36:18 PST
Marked test as flaky in https://trac.webkit.org/r227706
Comment 4 Truitt Savell 2018-08-08 09:31:57 PDT
This test is still flakey. It is now flakey on Release builds as well. Additionally it is flakey on iOS 11 Debug wk2. 

The issue still seems to be those two extra blank lines in the output
Comment 5 Alexey Proskuryakov 2018-08-08 09:42:39 PDT
The test itself is buggy - it starts checks on a zero timeout, but there is no guarantee that WebKit has already parsed </html> by that time. At the very least, it needs to use onload.

But I'm not sure if we care about imported/blink tests enough to fix them. Maybe just delete, or WontFix in TestExpectations.
Comment 6 Truitt Savell 2018-08-08 09:44:31 PDT
Adjusted test expectations in https://trac.webkit.org/changeset/234695/webkit
Comment 7 Truitt Savell 2018-08-09 09:20:07 PDT
*** Bug 188441 has been marked as a duplicate of this bug. ***
Comment 8 Karl Rackler 2022-04-20 14:02:29 PDT
[ macOS wk2 ] imported/blink/fast/text/international-iteration-simple-text.html is a flaky failure

Description:
imported/blink/fast/text/international-iteration-simple-text.html

The test is now affecting macOS wk2.

This new behaviors' first failure that I saw on the dashboard was 3/29/2022 at r292081, but this was to fix a build break and does not appear relevant to causing this issue.  This test seems to have been flaky since the start. 

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fblink%2Ffast%2Ftext%2Finternational-iteration-simple-text.html&platform=mac&limit=50000

Diff:
--- /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/imported/blink/fast/text/international-iteration-simple-text-expected.txt
+++ /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/imported/blink/fast/text/international-iteration-simple-text-actual.txt
@@ -1 +1,3 @@
 Test passes if it does not crash.
+
+ 


I have marked this test as a flaky failure while this issue is investigated.
Comment 9 Karl Rackler 2022-04-20 14:07:48 PDT
Pull request: https://github.com/WebKit/WebKit/pull/329
Comment 10 EWS 2022-04-20 14:11:11 PDT
Committed r293113 (249819@main): <https://commits.webkit.org/249819@main>

Reviewed commits have been landed. Closing PR #329 and removing active labels.
Comment 11 Karl Rackler 2022-04-20 14:11:47 PDT
Reopened because it is still being investigated.