Bug 179850 - Web Inspector: Update the Trash / Clear icon
Summary: Web Inspector: Update the Trash / Clear icon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 16:34 PST by Joseph Pecoraro
Modified: 2017-11-18 14:00 PST (History)
8 users (show)

See Also:

Attachments
[IMAGE] In Watch Expressions (263.60 KB, image/png)
2017-11-17 16:34 PST, Joseph Pecoraro 		no flags Details
[IMAGE] In Console (208.53 KB, image/png)
2017-11-17 16:35 PST, Joseph Pecoraro 		no flags Details
[IMAGE] In Network (257.53 KB, image/png)
2017-11-17 16:35 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (6.13 KB, patch)
2017-11-17 16:36 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-17 16:34:21 PST 
Update the Trash / Clear icon

Resize it slightly to fit with other icons. Change the design a bit so it seems more like a clear.
Comment 1 Joseph Pecoraro 2017-11-17 16:34:55 PST 
Created attachment 327268 [details]
[IMAGE] In Watch Expressions
Comment 2 Joseph Pecoraro 2017-11-17 16:35:06 PST 
Created attachment 327269 [details]
[IMAGE] In Console
Comment 3 Joseph Pecoraro 2017-11-17 16:35:19 PST 
Created attachment 327270 [details]
[IMAGE] In Network
Comment 4 Joseph Pecoraro 2017-11-17 16:36:21 PST 
Created attachment 327271 [details]
[PATCH] Proposed Fix
Comment 5 Matt Baker 2017-11-17 17:10:34 PST 
Why is it necessary to have top: 1px? If this adjustment will always be needed, would it make more sense to bake it into the SVG so that it looks good out of the box?
Comment 6 Joseph Pecoraro 2017-11-17 17:40:08 PST 
(In reply to Matt Baker from comment #5)
> Why is it necessary to have top: 1px? If this adjustment will always be
> needed, would it make more sense to bake it into the SVG so that it looks
> good out of the box?

This is only in the detail sidebars where it is next to 13x13 icons.

In the normal tabs there are no modifications.
Comment 7 Matt Baker 2017-11-18 13:39:19 PST 
(In reply to Joseph Pecoraro from comment #6)
> (In reply to Matt Baker from comment #5)
> > Why is it necessary to have top: 1px? If this adjustment will always be
> > needed, would it make more sense to bake it into the SVG so that it looks
> > good out of the box?
> 
> This is only in the detail sidebars where it is next to 13x13 icons.
> 
> In the normal tabs there are no modifications.

Makes sense!
Comment 8 Matt Baker 2017-11-18 13:39:31 PST 
Comment on attachment 327271 [details]
[PATCH] Proposed Fix

r=me
Comment 9 WebKit Commit Bot 2017-11-18 13:59:06 PST 
Comment on attachment 327271 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 327271

Committed r225019: <https://trac.webkit.org/changeset/225019>
Comment 10 WebKit Commit Bot 2017-11-18 13:59:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-11-18 14:00:32 PST 
<rdar://problem/35633559>