Bug 179848 - Use a strongly typed identifier for SWServer::Connection
Summary: Use a strongly typed identifier for SWServer::Connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 16:08 PST by Chris Dumez
Modified: 2017-11-17 18:28 PST (History)
9 users (show)

See Also:

Attachments
Patch (83.62 KB, patch)
2017-11-17 16:29 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (83.58 KB, patch)
2017-11-17 16:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (83.87 KB, patch)
2017-11-17 16:51 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-17 16:08:10 PST 
Use a strongly typed identifier for SWServer::Connection, for clarity.
Comment 1 Chris Dumez 2017-11-17 16:29:27 PST 
Created attachment 327266 [details]
Patch
Comment 2 Brady Eidson 2017-11-17 16:35:36 PST 
Comment on attachment 327266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327266&action=review

r+ with a naming comment

> Source/WTF/wtf/ObjectIdentifier.h:65
> +    uint64_t toUnsignedInteger() const { return m_identifier; }

toUInt64()
Comment 3 Chris Dumez 2017-11-17 16:37:55 PST 
Created attachment 327272 [details]
Patch
Comment 4 Chris Dumez 2017-11-17 16:51:10 PST 
Created attachment 327277 [details]
Patch
Comment 5 WebKit Commit Bot 2017-11-17 17:35:57 PST 
The commit-queue encountered the following flaky tests while processing attachment 327277 [details]:

The commit-queue is continuing to process your patch.
Comment 6 Chris Dumez 2017-11-17 18:27:19 PST 
Comment on attachment 327277 [details]
Patch

Clearing flags on attachment: 327277

Committed r225008: <https://trac.webkit.org/changeset/225008>
Comment 7 Chris Dumez 2017-11-17 18:27:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-11-17 18:28:21 PST 
<rdar://problem/35628606>