Bug 179843 - Web Inspector: Disabled ImageAndText-style buttons should have gray text
Summary: Web Inspector: Disabled ImageAndText-style buttons should have gray text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 14:35 PST by Matt Baker
Modified: 2017-11-17 15:18 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2017-11-17 14:36 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Patch for landing (1.49 KB, patch)
2017-11-17 15:02 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-11-17 14:35:10 PST 
Currently only the icon/glyph is grayed out.
Comment 1 Radar WebKit Bug Importer 2017-11-17 14:35:37 PST 
<rdar://problem/35624337>
Comment 2 Matt Baker 2017-11-17 14:36:26 PST 
Created attachment 327240 [details]
Patch
Comment 3 Joseph Pecoraro 2017-11-17 14:56:22 PST 
Comment on attachment 327240 [details]
Patch

rs=me

I think the `> span` part probably isn't necessary.
Comment 4 Matt Baker 2017-11-17 15:02:25 PST 
Created attachment 327250 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-11-17 15:18:32 PST 
Comment on attachment 327250 [details]
Patch for landing

Clearing flags on attachment: 327250

Committed r224993: <https://trac.webkit.org/changeset/224993>
Comment 6 WebKit Commit Bot 2017-11-17 15:18:33 PST 
All reviewed patches have been landed.  Closing bug.