Bug 179837 – AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

We currently have these methods:
1. rowHeaders() and columnHeaders()
2. getRowHeaders() and getColumnHeaders()

The methods in item 1 should return the headers if given a cell or a table. columnHeaders() does so, but rowHeaders() does not. These methods are to be implemented by all platforms, so we need to fix this.

The methods in item 1 should return an empty array and not nullptr upon failure. Tests might ask for the length of the array and we should handle that gracefully.

The methods in item 2 only get headers if given a table. Unlike the methods in item 1, these methods are just helper methods for our platform. Let's rename them to something a tad clearer.

The methods in item 2 call atk_table_get_{row,column}_header. Those ATK methods take an index and return a header if there's one there and otherwise null. We should not append null objects to the array of headers because it leads to bogus results.

[Radar WebKit Bug Importer]

<rdar://problem/35621868>

[Joanmarie Diggs]

*** Bug 176798 has been marked as a duplicate of this bug. ***

[Joanmarie Diggs]

Created attachment 327227 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 327227 [details]
Patch

Clearing flags on attachment: 327227

Committed r224986: <https://trac.webkit.org/changeset/224986>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.