Bug 179834 - Do not run webkitpy tests on multiple EWSes
Summary: Do not run webkitpy tests on multiple EWSes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 12:03 PST by Aakash Jain
Modified: 2017-11-27 17:27 PST (History)
8 users (show)

See Also:

Attachments
Proposed patch (2.72 KB, patch)
2017-11-17 12:12 PST, Aakash Jain 		ap: review+
Details | Formatted Diff | Diff
Updated patch (2.68 KB, patch)
2017-11-27 16:55 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-11-17 12:03:22 PST 
We now have a separate webkitpy test EWS which run webkitpy-tests on every patch (as appropriate).

Currently all the EWSes which run tests also run webkitpy tests, but ignore it's output. There is no point in running these tests and ignoring the output. We should remove this old code.
Comment 1 Aakash Jain 2017-11-17 12:12:20 PST 
To clarify, we don't want to run these tests on multiple EWSes. EWSes use the parameter --non-interactive. We still want to run these tests when running manually, i.e. when --non-interactive option is not passed.
Comment 2 Aakash Jain 2017-11-17 12:12:38 PST 
Created attachment 327210 [details]
Proposed patch
Comment 3 Alexey Proskuryakov 2017-11-18 21:10:41 PST 
Comment on attachment 327210 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327210&action=review

> Tools/Scripts/webkitpy/tool/steps/runtests.py:87
> +            python_unittests_command = self._tool.deprecated_port().run_python_unittests_command()

The FIXME above doesn’t seem accurate for webkitpy
Comment 4 Aakash Jain 2017-11-27 16:55:35 PST 
Created attachment 327716 [details]
Updated patch

Patch for landing.
Comment 5 WebKit Commit Bot 2017-11-27 17:21:43 PST 
Comment on attachment 327716 [details]
Updated patch

Clearing flags on attachment: 327716

Committed r225206: <https://trac.webkit.org/changeset/225206>
Comment 6 WebKit Commit Bot 2017-11-27 17:21:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-27 17:27:29 PST 
<rdar://problem/35712592>