Bug 179829 - Don't invert a matrix for every channel of every pixel of an FETurbulence filter
Summary: Don't invert a matrix for every channel of every pixel of an FETurbulence filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 10:46 PST by Simon Fraser (smfr)
Modified: 2017-11-17 16:58 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2017-11-17 10:49 PST, Simon Fraser (smfr) 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.51 MB, application/zip)
2017-11-17 11:46 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (2.94 MB, application/zip)
2017-11-17 12:25 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (3.01 MB, application/zip)
2017-11-17 13:20 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-11-17 10:46:38 PST 
First of a few FETurbulence optimizations.
Comment 1 Simon Fraser (smfr) 2017-11-17 10:49:47 PST 
Created attachment 327195 [details]
Patch
Comment 2 EWS Watchlist 2017-11-17 11:46:47 PST 
Comment on attachment 327195 [details]
Patch

Attachment 327195 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5277789

New failing tests:
svg/filters/feTurbulence_bad_seeds.html
Comment 3 EWS Watchlist 2017-11-17 11:46:48 PST 
Created attachment 327204 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 EWS Watchlist 2017-11-17 12:25:03 PST 
Comment on attachment 327195 [details]
Patch

Attachment 327195 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5278504

New failing tests:
svg/filters/feTurbulence_bad_seeds.html
Comment 5 EWS Watchlist 2017-11-17 12:25:04 PST 
Created attachment 327213 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 EWS Watchlist 2017-11-17 13:20:05 PST 
Comment on attachment 327195 [details]
Patch

Attachment 327195 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5279163

New failing tests:
svg/filters/feTurbulence_bad_seeds.html
Comment 7 EWS Watchlist 2017-11-17 13:20:06 PST 
Created attachment 327222 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Simon Fraser (smfr) 2017-11-17 15:08:23 PST 
Test failure was because of an unwanted rounding of a FloatPoint to an IntPoint. Fixed before landing.
Comment 9 Simon Fraser (smfr) 2017-11-17 15:37:11 PST 
https://trac.webkit.org/r224996
Comment 10 Radar WebKit Bug Importer 2017-11-17 15:39:00 PST 
<rdar://problem/35625910>
Comment 11 Ryan Haddad 2017-11-17 16:58:47 PST 
LayoutTest svg/W3C-SVG-1.1-SE/types-dom-04-b.svg is failing after this change:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r224997%20(6220)/results.html