WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179825
Add a TimingScope class for microbenchmarking sections of code
https://bugs.webkit.org/show_bug.cgi?id=179825
Summary
Add a TimingScope class for microbenchmarking sections of code
Simon Fraser (smfr)
Reported
2017-11-17 10:03:15 PST
I keep writing code that computes the duration taken by a chunk of code, averaging over some number of calls and printing the result using WTFLogAlways. This should be wrapped in stack-based helper class.
Attachments
Patch
(11.05 KB, patch)
2017-11-17 10:07 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2017-11-17 10:07:03 PST
Created
attachment 327189
[details]
Patch
Simon Fraser (smfr)
Comment 2
2017-11-17 10:08:02 PST
Maybe this and B3TimingScope should share code at some point, but I don't think that's necessary for a small utility class right now.
EWS Watchlist
Comment 3
2017-11-17 10:08:33 PST
Attachment 327189
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/TimingScope.cpp:67: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4
2017-11-17 15:00:47 PST
Comment on
attachment 327189
[details]
Patch Clearing flags on attachment: 327189 Committed
r224990
: <
https://trac.webkit.org/changeset/224990
>
WebKit Commit Bot
Comment 5
2017-11-17 15:00:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2017-11-17 15:01:31 PST
<
rdar://problem/35624957
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug