Bug 179819 - Move destroyLeftoverChildren call to RenderObject::destroy
Summary: Move destroyLeftoverChildren call to RenderObject::destroy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-17 07:15 PST by Antti Koivisto
Modified: 2017-11-17 11:34 PST (History)
7 users (show)

See Also:


Attachments
patch (1.30 KB, patch)
2017-11-17 07:17 PST, Antti Koivisto
zalan: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (3.27 MB, application/zip)
2017-11-17 08:11 PST, Build Bot
no flags Details
patch (2.21 KB, patch)
2017-11-17 08:33 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (5.10 KB, patch)
2017-11-17 09:22 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (5.66 KB, patch)
2017-11-17 09:57 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-11-17 07:15:52 PST
For safety.
Comment 1 Antti Koivisto 2017-11-17 07:17:44 PST
Created attachment 327169 [details]
patch
Comment 2 zalan 2017-11-17 07:23:32 PST
Comment on attachment 327169 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327169&action=review

> Source/WebCore/ChangeLog:3
> +        Add release assert that RenderLayer is out of tree before destruction

..is detached before destruction?
Comment 3 Build Bot 2017-11-17 08:11:29 PST
Comment on attachment 327169 [details]
patch

Attachment 327169 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5274607

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-11-17 08:11:30 PST
Created attachment 327173 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Antti Koivisto 2017-11-17 08:33:50 PST
Created attachment 327175 [details]
patch
Comment 6 Antti Koivisto 2017-11-17 09:22:27 PST
Created attachment 327184 [details]
patch
Comment 7 Antti Koivisto 2017-11-17 09:57:29 PST
Created attachment 327188 [details]
patch
Comment 8 Radar WebKit Bug Importer 2017-11-17 10:40:30 PST
<rdar://problem/35618234>
Comment 9 WebKit Commit Bot 2017-11-17 11:34:36 PST
Comment on attachment 327188 [details]
patch

Clearing flags on attachment: 327188

Committed r224976: <https://trac.webkit.org/changeset/224976>
Comment 10 WebKit Commit Bot 2017-11-17 11:34:38 PST
All reviewed patches have been landed.  Closing bug.