Bug 179817 - [WPE] Build C API tests
Summary: [WPE] Build C API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 173770
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-17 05:47 PST by Carlos Garcia Campos
Modified: 2017-11-20 01:51 PST (History)
2 users (show)

See Also:


Attachments
Patch (16.67 KB, patch)
2017-11-17 05:49 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-17 05:47:54 PST
They aren't build for WPE.
Comment 1 Carlos Garcia Campos 2017-11-17 05:49:28 PST
Created attachment 327165 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-11-17 06:12:06 PST
This is not expected to build since it depends on two other patches.
Comment 3 Michael Catanzaro 2017-11-17 07:35:16 PST
Comment on attachment 327165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327165&action=review

> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:68
> +    if (m_window)
> +        delete m_window;

delete is NULL-safe, so remove the if (m_window) check.

> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:89
> +    // FIXME: implement this.

What happened to using notImplemented()? :D
Comment 4 Carlos Garcia Campos 2017-11-17 08:29:32 PST
Comment on attachment 327165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327165&action=review

>> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:68
>> +        delete m_window;
> 
> delete is NULL-safe, so remove the if (m_window) check.

Right!

>> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:89
>> +    // FIXME: implement this.
> 
> What happened to using notImplemented()? :D

notImplemented() is WebCore API.
Comment 5 Carlos Garcia Campos 2017-11-20 01:51:16 PST
Committed r225046: <https://trac.webkit.org/changeset/225046>