Bug 179808 - Navigation requests should use navigate fetch mode
Summary: Navigation requests should use navigate fetch mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 180702
  Show dependency tree / graph
 
Reported: 2017-11-16 17:40 PST by youenn fablet
Modified: 2017-12-12 12:44 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.60 KB, patch)
2017-11-16 17:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (10.91 KB, patch)
2017-12-12 10:28 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-16 17:40:51 PST 
Navigation requests should use navigate fetch mode
Comment 1 youenn fablet 2017-11-16 17:49:48 PST 
Created attachment 327137 [details]
Patch
Comment 2 youenn fablet 2017-12-12 10:28:30 PST 
Created attachment 329124 [details]
Patch
Comment 3 youenn fablet 2017-12-12 11:15:11 PST 
Comment on attachment 329124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329124&action=review

> LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:2
> +FAIL Test FetchEvent.request passed to onfetch assert_equals: Constructing a Request with a Request whose mode is navigate and non-empty RequestInit must throw a TypeError. expected "TypeError" but got ""

Test is making progress here. It is failing on the last check.
This last check is actually wrong as per last fetch spec : constructor no longer throws that way, it silently change the mode to SameOrigin.
We should update the WPT test upstream.
Comment 4 WebKit Commit Bot 2017-12-12 12:43:36 PST 
Comment on attachment 329124 [details]
Patch

Clearing flags on attachment: 329124

Committed r225796: <https://trac.webkit.org/changeset/225796>
Comment 5 WebKit Commit Bot 2017-12-12 12:43:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-12 12:44:23 PST 
<rdar://problem/36001655>