RESOLVED FIXED 179806
REGRESSION (224348?): [mac-wk1] LayoutTest media/video-src-remove.html is a flaky timeout 
https://bugs.webkit.org/show_bug.cgi?id=179806
Summary REGRESSION (224348?): [mac-wk1] LayoutTest media/video-src-remove.html is a f...
Attachments
Patch (2.22 KB, patch)
2017-11-17 15:45 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2017-11-17 16:14 PST, Alex Christensen 		jer.noble: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-11-16 17:11:06 PST
This is limited to Mac-wk1 debug bots. The earliest timeout on the dashboard blames https://trac.webkit.org/log/webkit/?verbose=on&rev=224350&stop_rev=224349 (but this is a flaky timeout).
Alexey Proskuryakov
Comment 2 2017-11-16 21:35:51 PST
Possibly <http://trac.webkit.org/projects/webkit/changeset/224348>?
Alexey Proskuryakov
Comment 3 2017-11-16 21:37:24 PST
This test was absolutely stable, and now times out very frequently.
Radar WebKit Bug Importer
Comment 4 2017-11-16 21:38:55 PST
<rdar://problem/35608336>
Alex Christensen
Comment 5 2017-11-17 15:43:07 PST
I can reproduce this quite reliably with guardmalloc. We needed callOnMainThread for UIWebView to work correctly with the web thread, but I guess we need dispatch_async on mac.
Alex Christensen
Comment 6 2017-11-17 15:45:39 PST
Created attachment 327257 [details] Patch
Alex Christensen
Comment 7 2017-11-17 16:14:16 PST
Created attachment 327263 [details] Patch
Alex Christensen
Comment 8 2017-11-17 17:01:02 PST
http://trac.webkit.org/r225003
Alexey Proskuryakov
Comment 9 2017-11-27 10:52:45 PST
Thanks for fixing the test! Not sure if this is the right kind of technical debt to have long term though, this sounds very fragile.
Alex Christensen
Comment 10 2017-11-27 10:53:36 PST
Long-term we should deprecate and remove WebView.scheduleInRunLoop
Alex Christensen
Comment 11 2017-11-27 10:54:10 PST
And stop using the web thread in UIWebView
Note You need to log in before you can comment on or make changes to this bug.