179806 – REGRESSION (224348?): [mac-wk1] LayoutTest media/video-src-remove.html is a flaky timeout

Bug 179806 - REGRESSION (224348?): [mac-wk1] LayoutTest media/video-src-remove.html is a flaky timeout

Summary: REGRESSION (224348?): [mac-wk1] LayoutTest media/video-src-remove.html is a f...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-11-16 17:08 PST by Ryan Haddad
Modified:	2018-01-18 12:36 PST (History)
CC List:	6 users (show)

See Also:	181553

Attachments
Patch (2.22 KB, patch) 2017-11-17 15:45 PST, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (2.22 KB, patch) 2017-11-17 16:14 PST, Alex Christensen	jer.noble: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ryan Haddad 2017-11-16 17:08:48 PST

LayoutTest media/video-src-remove.html is a flaky timeout

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224926%20(4889)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-src-remove.html

Comment 1 Ryan Haddad 2017-11-16 17:11:06 PST

This is limited to Mac-wk1 debug bots. The earliest timeout on the dashboard blames https://trac.webkit.org/log/webkit/?verbose=on&rev=224350&stop_rev=224349 (but this is a flaky timeout).

Comment 2 Alexey Proskuryakov 2017-11-16 21:35:51 PST

Possibly <http://trac.webkit.org/projects/webkit/changeset/224348>?

Comment 3 Alexey Proskuryakov 2017-11-16 21:37:24 PST

This test was absolutely stable, and now times out very frequently.

Comment 4 Radar WebKit Bug Importer 2017-11-16 21:38:55 PST

<rdar://problem/35608336>

Comment 5 Alex Christensen 2017-11-17 15:43:07 PST

I can reproduce this quite reliably with guardmalloc.  We needed callOnMainThread for UIWebView to work correctly with the web thread, but I guess we need dispatch_async on mac.

Comment 6 Alex Christensen 2017-11-17 15:45:39 PST

Created attachment 327257 [details]
Patch

Comment 7 Alex Christensen 2017-11-17 16:14:16 PST

Created attachment 327263 [details]
Patch

Comment 8 Alex Christensen 2017-11-17 17:01:02 PST

http://trac.webkit.org/r225003

Comment 9 Alexey Proskuryakov 2017-11-27 10:52:45 PST

Thanks for fixing the test!

Not sure if this is the right kind of technical debt to have long term though, this sounds very fragile.

Comment 10 Alex Christensen 2017-11-27 10:53:36 PST

Long-term we should deprecate and remove WebView.scheduleInRunLoop

Comment 11 Alex Christensen 2017-11-27 10:54:10 PST

And stop using the web thread in UIWebView