Bug 179803 - ServiceWorker intercepted FetchRequests should have their referrer set appropriately.
Summary: ServiceWorker intercepted FetchRequests should have their referrer set approp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-16 16:13 PST by youenn fablet
Modified: 2017-11-17 10:40 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.40 KB, patch)
2017-11-16 16:21 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.53 KB, patch)
2017-11-16 18:59 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.64 MB, application/zip)
2017-11-16 20:06 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-16 16:13:05 PST 
ServiceWorker intercepted FetchRequest should have their referrer set appropriately.
Comment 1 youenn fablet 2017-11-16 16:21:11 PST 
Created attachment 327125 [details]
Patch
Comment 2 Chris Dumez 2017-11-16 16:23:14 PST 
Comment on attachment 327125 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-11-16 18:42:34 PST 
Comment on attachment 327125 [details]
Patch

Rejecting attachment 327125 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327125, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
kerFetch.cpp.rej
patching file LayoutTests/imported/w3c/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/referer.https-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5267732
Comment 4 youenn fablet 2017-11-16 18:59:29 PST 
Created attachment 327143 [details]
Patch for landing
Comment 5 EWS Watchlist 2017-11-16 20:06:47 PST 
Comment on attachment 327143 [details]
Patch for landing

Attachment 327143 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5268145

New failing tests:
http/tests/appcache/resource-redirect-2.html
Comment 6 EWS Watchlist 2017-11-16 20:06:49 PST 
Created attachment 327147 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 WebKit Commit Bot 2017-11-17 10:34:00 PST 
Comment on attachment 327143 [details]
Patch for landing

Clearing flags on attachment: 327143

Committed r224971: <https://trac.webkit.org/changeset/224971>
Comment 8 WebKit Commit Bot 2017-11-17 10:34:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-11-17 10:40:28 PST 
<rdar://problem/35618233>