Bug 179774 - Make sure service workers get terminated between tests
Summary: Make sure service workers get terminated between tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-16 09:10 PST by Chris Dumez
Modified: 2017-11-16 18:33 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2017-11-16 12:07 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.90 KB, patch)
2017-11-16 13:18 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-16 09:10:14 PST 
Make sure service workers get terminated between tests.
Comment 1 Chris Dumez 2017-11-16 12:07:06 PST 
Created attachment 327093 [details]
Patch
Comment 2 Brady Eidson 2017-11-16 12:32:49 PST 
Comment on attachment 327093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327093&action=review

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:52
> +        clearRegistration(*registration);

What is the intended side effect of clearRegistration?

Is this what is called when a WebPage actually clears its service worker?

If so, this patch would have the side effect of clearing *persistent* registrations too, and we don't want to do this between tests.
Comment 3 Chris Dumez 2017-11-16 13:18:50 PST 
Created attachment 327099 [details]
Patch
Comment 4 WebKit Commit Bot 2017-11-16 18:32:16 PST 
Comment on attachment 327099 [details]
Patch

Clearing flags on attachment: 327099

Committed r224955: <https://trac.webkit.org/changeset/224955>
Comment 5 WebKit Commit Bot 2017-11-16 18:32:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-16 18:33:19 PST 
<rdar://problem/35605947>