Bug 179764 - Fix null pointer dereference in bytecodeDumper
Summary: Fix null pointer dereference in bytecodeDumper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-16 06:06 PST by Robin Morisset
Modified: 2017-11-17 13:01 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2017-11-16 06:09 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2017-11-16 06:06:26 PST 
Found accidentally by running dumping bytecode in a version of JSC compiled with ASAN.
The problem is just a call to lastSeenCallee on a CallLinkInfo that was unguarded by haveLastSeenCallee().
Comment 1 Robin Morisset 2017-11-16 06:09:42 PST 
Created attachment 327059 [details]
Patch
Comment 2 Mark Lam 2017-11-16 06:47:54 PST 
Comment on attachment 327059 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-11-16 07:08:14 PST 
Comment on attachment 327059 [details]
Patch

Clearing flags on attachment: 327059

Committed r224916: <https://trac.webkit.org/changeset/224916>
Comment 4 WebKit Commit Bot 2017-11-16 07:08:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-17 13:01:34 PST 
<rdar://problem/35621867>