Bug 179752 - [EME] Support generateRequest() in CDMFairPlayStreaming
Summary: [EME] Support generateRequest() in CDMFairPlayStreaming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-15 17:26 PST by Jer Noble
Modified: 2017-12-07 11:47 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.45 KB, patch)
2017-11-15 17:39 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (16.46 KB, patch)
2017-12-05 08:42 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (17.70 KB, patch)
2017-12-07 11:08 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-11-15 17:26:29 PST 
[EME] SUpport generateRequest() in CDMFairPlayStreaming
Comment 1 Jer Noble 2017-11-15 17:39:33 PST 
Created attachment 327040 [details]
Patch
Comment 2 Jer Noble 2017-12-05 08:42:12 PST 
Created attachment 328453 [details]
Patch
Comment 3 Eric Carlson 2017-12-06 16:31:37 PST 
Comment on attachment 328453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328453&action=review

> Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:143
> +        if (result.first == "cbcs" || result.first == "cbc2" || result.first == "cbc1")

Nit: these strings are used in several places, you should make them statics with MAKE_STATIC_STRING_IMPL().

> Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:163
> +    InitDataRegistry::shared().registerInitDataType("sinf", { CDMPrivateFairPlayStreaming::sanitizeSinf, CDMPrivateFairPlayStreaming::extractKeyIDsSinf });

Nit: ASCIILiteral("sinf")
Comment 4 Jer Noble 2017-12-07 11:08:42 PST 
Created attachment 328708 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-12-07 11:46:57 PST 
Comment on attachment 328708 [details]
Patch for landing

Clearing flags on attachment: 328708

Committed r225637: <https://trac.webkit.org/changeset/225637>
Comment 6 WebKit Commit Bot 2017-12-07 11:46:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-07 11:47:18 PST 
<rdar://problem/35914966>