Bug 179749 - Fix fast/events/message-port-postMessage-recursive.html after r224896
Summary: Fix fast/events/message-port-postMessage-recursive.html after r224896
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-15 16:13 PST by Alex Christensen
Modified: 2017-11-16 22:16 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2017-11-15 16:15 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2017-11-15 16:19 PST, Alex Christensen 		jer.noble: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-11-15 16:13:00 PST 
Fix fast/events/message-port-postMessage-recursive.html after r224896
Comment 1 Alex Christensen 2017-11-15 16:15:46 PST 
Created attachment 327033 [details]
Patch
Comment 2 Alex Christensen 2017-11-15 16:19:37 PST 
Created attachment 327034 [details]
Patch
Comment 3 Alex Christensen 2017-11-15 16:36:51 PST 
https://trac.webkit.org/changeset/224907/webkit
Comment 4 Radar WebKit Bug Importer 2017-11-15 16:38:15 PST 
<rdar://problem/35575676>
Comment 5 Alexey Proskuryakov 2017-11-16 22:16:18 PST 
Comment on attachment 327034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327034&action=review

> Source/WTF/wtf/mac/MainThreadMac.mm:128
> +    return currentMode == (NSString *)kCFRunLoopCommonModes

I don't see how this can work. According to documentation, "Run loops never run in this mode".

https://developer.apple.com/documentation/corefoundation/cfrunloop/common_mode_flag