Bug 179729 – [Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adrian Perez]

The warning itself should be harmless, but it pops a few times during compilation
and we would rather have build output as clean as possible. Warning message follows.

---

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource332.cpp:2:
In file included from ../../Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:34:
../../Source/WebCore/platform/graphics/cairo/CairoOperations.h:51:1: warning: class 'GraphicsContextState' was previously declared as a struct [-Wmismatched-tags]
class GraphicsContextState;
^
../../Source/WebCore/platform/graphics/GraphicsContext.h:116:8: note: previous use is here
struct GraphicsContextState {
       ^
../../Source/WebCore/platform/graphics/cairo/CairoOperations.h:51:1: note: did you mean struct here?
class GraphicsContextState;
^~~~~
struct

[Adrian Perez]

Created attachment 326980 [details]
Patch

[Michael Catanzaro]

Comment on attachment 326980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326980&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:51
> +struct GraphicsContextState;

I think it should follow the class declarations, with a blank line in between.

[Adrian Perez]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 326980 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326980&action=review
> 
> > Source/WebCore/platform/graphics/cairo/CairoOperations.h:51
> > +struct GraphicsContextState;
> 
> I think it should follow the class declarations, with a blank line in
> between.


TBH, I was surprised that the style checker didn't complain now
that there's both “class” and “struct” mixed in a block of forward
declarations. Let's try your suggestion and see whether it will
complain or accept it ;-)

[Adrian Perez]

Created attachment 326983 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 326983 [details]
Patch

Clearing flags on attachment: 326983

Committed r224882: <https://trac.webkit.org/changeset/224882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35566940>