Bug 179727 – [WPE] Add initial support for WebDriver

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

Add initial support for WebDriver to WPE port.

[Carlos Garcia Campos]

Created attachment 326979 [details]
Patch

[Michael Catanzaro]

Comment on attachment 326979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326979&action=review

> Source/cmake/OptionsWPE.cmake:37
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE ON)

I think Adrian wants this to be public, since he has support in his Buildroot recipe for enabling and disabling it.

Adrian, do you want to keep that support? (I think the Buildroot recipe should only touch public options.)

[Adrian Perez]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 326979 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326979&action=review
> 
> > Source/cmake/OptionsWPE.cmake:37
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE ON)
> 
> I think Adrian wants this to be public, since he has support in his
> Buildroot recipe for enabling and disabling it.
> 
> Adrian, do you want to keep that support? (I think the Buildroot recipe
> should only touch public options.)

Yes, I would like to keep it as a public option, as long as it is
reasonable from a maintenance POV. The reasons are that it is already
a public option in the GTK+ port, and that in embedded devices every
few hundred kilobytes count — people may want to have WebDriver
enabled for development, and disabled for releases.

[Carlos Garcia Campos]

Committed r224913: <https://trac.webkit.org/changeset/224913>