Bug 179727 - [WPE] Add initial support for WebDriver
Summary: [WPE] Add initial support for WebDriver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-15 05:13 PST by Carlos Garcia Campos
Modified: 2017-11-16 04:48 PST (History)
4 users (show)

See Also:


Attachments
Patch (21.73 KB, patch)
2017-11-15 05:21 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-15 05:13:20 PST
Add initial support for WebDriver to WPE port.
Comment 1 Carlos Garcia Campos 2017-11-15 05:21:21 PST
Created attachment 326979 [details]
Patch
Comment 2 Michael Catanzaro 2017-11-15 07:09:41 PST
Comment on attachment 326979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326979&action=review

> Source/cmake/OptionsWPE.cmake:37
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE ON)

I think Adrian wants this to be public, since he has support in his Buildroot recipe for enabling and disabling it.

Adrian, do you want to keep that support? (I think the Buildroot recipe should only touch public options.)
Comment 3 Adrian Perez 2017-11-15 07:37:52 PST
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 326979 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326979&action=review
> 
> > Source/cmake/OptionsWPE.cmake:37
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE ON)
> 
> I think Adrian wants this to be public, since he has support in his
> Buildroot recipe for enabling and disabling it.
> 
> Adrian, do you want to keep that support? (I think the Buildroot recipe
> should only touch public options.)

Yes, I would like to keep it as a public option, as long as it is
reasonable from a maintenance POV. The reasons are that it is already
a public option in the GTK+ port, and that in embedded devices every
few hundred kilobytes count — people may want to have WebDriver
enabled for development, and disabled for releases.
Comment 4 Carlos Garcia Campos 2017-11-16 04:48:38 PST
Committed r224913: <https://trac.webkit.org/changeset/224913>