Bug 179710 - Clean up URL.h
Summary: Clean up URL.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-14 16:51 PST by Alex Christensen
Modified: 2017-11-20 22:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2017-11-14 16:52 PST, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-11-14 16:51:25 PST 
Clean up URL.h
Comment 1 Alex Christensen 2017-11-14 16:52:49 PST 
Created attachment 326947 [details]
Patch
Comment 2 Alex Christensen 2017-11-17 13:38:31 PST 
http://trac.webkit.org/r224984
Comment 3 Radar WebKit Bug Importer 2017-11-17 13:39:37 PST 
<rdar://problem/35622767>
Comment 4 Darin Adler 2017-11-20 22:09:29 PST 
Comment on attachment 326947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326947&action=review

> Source/WebCore/platform/URL.h:459
> +// URLHash is the default hash for String

I think this should say URLHash is the default hash for *URL*, not String.

> Source/WebCore/platform/URL.h:460
> +template<typename T> struct DefaultHash;

No need for "T" here, just <typename>.

> Source/WebCore/platform/URL.h:462
> +    typedef WebCore::URLHash Hash;

Should use "using" instead of typedef if touching this.