RESOLVED FIXED 179710
Clean up URL.h 
https://bugs.webkit.org/show_bug.cgi?id=179710
Summary Clean up URL.h
Alex Christensen
Reported 2017-11-14 16:51:25 PST
Clean up URL.h
Attachments
Patch (4.74 KB, patch)
2017-11-14 16:52 PST, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-11-14 16:52:49 PST
Created attachment 326947 [details] Patch
Alex Christensen
Comment 2 2017-11-17 13:38:31 PST
http://trac.webkit.org/r224984
Radar WebKit Bug Importer
Comment 3 2017-11-17 13:39:37 PST
<rdar://problem/35622767>
Darin Adler
Comment 4 2017-11-20 22:09:29 PST
Comment on attachment 326947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326947&action=review > Source/WebCore/platform/URL.h:459 > +// URLHash is the default hash for String I think this should say URLHash is the default hash for *URL*, not String. > Source/WebCore/platform/URL.h:460 > +template<typename T> struct DefaultHash; No need for "T" here, just <typename>. > Source/WebCore/platform/URL.h:462 > + typedef WebCore::URLHash Hash; Should use "using" instead of typedef if touching this.
Note You need to log in before you can comment on or make changes to this bug.