Bug 179709 - [Service Workers] Implement Client API
Summary: [Service Workers] Implement Client API
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2017-11-14 16:44 PST by Chris Dumez
Modified: 2017-11-15 11:51 PST (History)
7 users (show)

See Also:

Patch (55.32 KB, patch)
2017-11-14 19:34 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (59.96 KB, patch)
2017-11-15 09:26 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-14 16:44:38 PST
Implement Client API:
- https://w3c.github.io/ServiceWorker/#client-interface
Comment 1 Chris Dumez 2017-11-14 19:34:18 PST
Created attachment 326961 [details]
Comment 2 Alex Christensen 2017-11-14 23:39:22 PST
Comment on attachment 326961 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=326961&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.h:809
> +template <> struct EnumTraits<WebCore::ServiceWorkerClientType> {

Could we just put these in WebCore?
Comment 3 Chris Dumez 2017-11-15 09:26:38 PST
Created attachment 326990 [details]
Comment 4 WebKit Commit Bot 2017-11-15 10:00:29 PST
Comment on attachment 326990 [details]

Clearing flags on attachment: 326990

Committed r224880: <https://trac.webkit.org/changeset/224880>
Comment 5 WebKit Commit Bot 2017-11-15 10:00:31 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 10:04:41 PST
Comment 7 Ryan Haddad 2017-11-15 11:31:08 PST
The LayoutTests added with this change are timing out on the bots:

Comment 8 Chris Dumez 2017-11-15 11:51:02 PST
(In reply to Ryan Haddad from comment #7)
> The LayoutTests added with this change are timing out on the bots:
> https://build.webkit.org/results/
> Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224880%20(1174)/results.html

It conflicted with Youenn's patch that landed right before mine. Should be fixed in <https://trac.webkit.org/changeset/224892>.