Bug 179702 - Add WebKitAdditions extension point to add user-agent stylesheet
Summary: Add WebKitAdditions extension point to add user-agent stylesheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-14 16:04 PST by Daniel Bates
Modified: 2017-11-28 10:34 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.03 KB, patch)
2017-11-14 16:17 PST, Daniel Bates 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-11-14 16:04:06 PST 
Add WebKitAdditions extension point to add user-agent stylesheet.

This is will be used towards <rdar://problem/34917108>.
Comment 1 Daniel Bates 2017-11-14 16:17:00 PST 
Created attachment 326937 [details]
Patch
Comment 2 Andy Estes 2017-11-16 10:33:41 PST 
Comment on attachment 326937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326937&action=review

> Source/WebCore/DerivedSources.make:1218
> +USER_AGENT_STYLE_SHEETS = css/html.css css/quirks.css css/plugIns.css
> +USER_AGENT_STYLE_SHEETS += css/svg.css

Why does svg.css have to be appended separately?
Comment 3 Daniel Bates 2017-11-16 12:13:32 PST 
Comment on attachment 326937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326937&action=review

>> Source/WebCore/DerivedSources.make:1218
>> +USER_AGENT_STYLE_SHEETS += css/svg.css
> 
> Why does svg.css have to be appended separately?

It does not need to be. Will fix before landing.
Comment 4 Daniel Bates 2017-11-16 14:23:42 PST Comment hidden (obsolete)
Comment 5 Radar WebKit Bug Importer 2017-11-27 16:23:34 PST 
<rdar://problem/35711147>
Comment 6 Daniel Bates 2017-11-28 10:34:05 PST 
Committed r225224: <https://trac.webkit.org/changeset/225224>