Bug 179696 – [Cocoa] Clean up names of conversion methods after renaming InspectorValue to JSON::Value

• Status: NEW
• Component: Web Inspector

[Blaze Burg]

"This space is intentionally left blank."

[Radar WebKit Bug Importer]

<rdar://problem/35544951>

[Blaze Burg]

Created attachment 326945 [details]
Patch

[Build Bot]

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[Blaze Burg]

Created attachment 327797 [details]
Rebased Patch

[Timothy Hatcher]

Comment on attachment 327797 [details]
Rebased Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327797&action=review

Looks fine other than one comment.

> Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:115
> -        lines.append('- (instancetype)initWithJSONObject:(RWIProtocolJSONObject *)jsonObject')
> +        lines.append('- (instancetype)initWithProtocolObject:(RWIProtocolJSONObject *)object')
>          lines.append('{')
> -        lines.append('    if (!(self = [super initWithInspectorObject:[jsonObject toInspectorObject].get()]))')
> +        lines.append('    if (!(self = [super initWithJSONObject:[object toJSONObject].get()]))')

This seems odd. Why change [self initWithJSONObject:] to initWithProtocolObject: when super is changing to initWithJSONObject:?

Maybe this method should be initWithProtocolJSONObject:?

[Blaze Burg]

(In reply to Timothy Hatcher from comment #5)
> Comment on attachment 327797 [details]
> Rebased Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327797&action=review
> 
> Looks fine other than one comment.
> 
> > Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:115
> > -        lines.append('- (instancetype)initWithJSONObject:(RWIProtocolJSONObject *)jsonObject')
> > +        lines.append('- (instancetype)initWithProtocolObject:(RWIProtocolJSONObject *)object')
> >          lines.append('{')
> > -        lines.append('    if (!(self = [super initWithInspectorObject:[jsonObject toInspectorObject].get()]))')
> > +        lines.append('    if (!(self = [super initWithJSONObject:[object toJSONObject].get()]))')
> 
> This seems odd. Why change [self initWithJSONObject:] to
> initWithProtocolObject: when super is changing to initWithJSONObject:?
> 
> Maybe this method should be initWithProtocolJSONObject:?

I thought it was more sensible to let super be able to use initWithJSONObject rather than keep it in the subclass. Among the two names, I chose the shorter one.

[Blaze Burg]

Comment on attachment 327797 [details]
Rebased Patch

<https://trac.webkit.org/r225243>