...
Created attachment 327047 [details] patch
Attachment 327047 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:95: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:119: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/dfg/DFGNodeType.h:461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 327047 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=327047&action=review r=me > Source/JavaScriptCore/tools/JSDollarVM.cpp:150 > + return JSValue::encode(jsBoolean(false)); Need to add UNUSED_PARAM(exec) to placate the other builds here. > Source/JavaScriptCore/tools/JSDollarVM.cpp:367 > + putDirectNativeFunction(vm, globalObject, Identifier::fromString(&vm, "CPUMfence"), 0, > + functionCPUMfence, CPUMfenceIntrinsic, 0); nit: why not prefix the JS function name with lower case "cpu" instead of "CPU"? I think starting with lower case is more consistent with WebKit convention. Ditto for the others below as well.
Comment on attachment 327047 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=327047&action=review >> Source/JavaScriptCore/tools/JSDollarVM.cpp:367 >> + functionCPUMfence, CPUMfenceIntrinsic, 0); > > nit: why not prefix the JS function name with lower case "cpu" instead of "CPU"? I think starting with lower case is more consistent with WebKit convention. Ditto for the others below as well. sounds good
Created attachment 327090 [details] patch for landing
Attachment 327090 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGNodeType.h:461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:95: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:119: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 327095 [details] patch for landing Don't do inline asm for OS(WINDOWS)
Attachment 327095 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGNodeType.h:461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:95: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:119: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 327095 [details] patch for landing Clearing flags on attachment: 327095 Committed r224938: <https://trac.webkit.org/changeset/224938>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35601358>
Follow up fix for cpuid landed in: https://trac.webkit.org/changeset/224942/webkit