Bug 179692 - Add feature define for alternative presentation button element
Summary: Add feature define for alternative presentation button element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 179785
  Show dependency tree / graph
 
Reported: 2017-11-14 13:57 PST by Daniel Bates
Modified: 2017-11-16 17:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (55.06 KB, patch)
2017-11-14 14:06 PST, Daniel Bates 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-11-14 13:57:01 PST 
Add feature define for alternative presentation button element.
Comment 1 Daniel Bates 2017-11-14 14:06:52 PST 
Created attachment 326924 [details]
Patch
Comment 2 Daniel Bates 2017-11-14 14:38:30 PST 
Part of <rdar://problem/34917108>
Comment 3 Andy Estes 2017-11-16 10:31:21 PST 
Comment on attachment 326924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326924&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252
> +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT;

I know that FeatureDefines are currently not sorted properly, but it would be nice to not make it worse. Can you put this between ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY?
Comment 4 Daniel Bates 2017-11-16 14:24:14 PST 
(In reply to Andy Estes from comment #3)
> Comment on attachment 326924 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326924&action=review
> 
> > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252
> > +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT;
> 
> I know that FeatureDefines are currently not sorted properly, but it would
> be nice to not make it worse. Can you put this between
> ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY?

Will fix before landing.
Comment 5 Daniel Bates 2017-11-16 14:24:19 PST 
Part of <rdar://problem/34917108>.
Comment 6 Daniel Bates 2017-11-16 17:17:34 PST 
Committed r224950: <https://trac.webkit.org/changeset/224950>