Bug 179692 – Add feature define for alternative presentation button element

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Add feature define for alternative presentation button element.

[Daniel Bates]

Created attachment 326924 [details]
Patch

[Daniel Bates]

Part of <rdar://problem/34917108>

[Andy Estes]

Comment on attachment 326924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326924&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252
> +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT;

I know that FeatureDefines are currently not sorted properly, but it would be nice to not make it worse. Can you put this between ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY?

[Daniel Bates]

(In reply to Andy Estes from comment #3)
> Comment on attachment 326924 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326924&action=review
> 
> > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252
> > +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT;
> 
> I know that FeatureDefines are currently not sorted properly, but it would
> be nice to not make it worse. Can you put this between
> ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY?

Will fix before landing.

[Daniel Bates]

Part of <rdar://problem/34917108>.

[Daniel Bates]

Committed r224950: <https://trac.webkit.org/changeset/224950>