See the discussion of https://bugs.webkit.org/show_bug.cgi?id=170272. > Checking the code, it seems that RenderMathMLUnderOver::computeOperatorsHorizontalStretch is actually only called in RenderMathMLUnderOver::layoutBlock, just before some calls to layoutIfNeeded() on the munderover children... but I believe these layoutIfNeeded calls are useless as we already do the layout in computeOperatorsHorizontalStretch. Also, computeOperatorsHorizontalStretch really does operator stretching and child layout, so the name is not good (I guess this was inherited from old implementation). So I propose you open a preliminary cleanup bug to rename "computeOperatorsHorizontalStretch" to "stretchHorizontalOperatorsAndLayoutChildren" and remove the useless layoutIfNeeded calls, so that things are a bit clearer. That won't require new tests and you would be able to experience the contribution process.
So more precisely, I was proposing: 1. Rename "computeOperatorsHorizontalStretch" to "stretchHorizontalOperatorsAndLayoutChildren". 2. Replace layoutIfNeeded() calls in RenderMathMLUnderOver::layoutBlock() with: ASSERT(!base().needsLayout()); ASSERT(m_scriptType == Over || !under().needsLayout()); ASSERT(m_scriptType == Under || !over().needsLayout());
Created attachment 327588 [details] Patch
Attachment 327588 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 327589 [details] Patch
Comment on attachment 327589 [details] Patch Thanks!
Comment on attachment 327589 [details] Patch Clearing flags on attachment: 327589 Committed r225148: <https://trac.webkit.org/changeset/225148>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35690291>