Bug 179671 - Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
Summary: Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-14 09:54 PST by Dean Jackson
Modified: 2017-11-14 14:16 PST (History)
9 users (show)

See Also:

Attachments
Patch (8.99 KB, patch)
2017-11-14 09:59 PST, Dean Jackson 		graouts: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-11-14 09:54:53 PST 
Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
Comment 1 Radar WebKit Bug Importer 2017-11-14 09:55:10 PST 
<rdar://problem/35534018>
Comment 2 Dean Jackson 2017-11-14 09:59:27 PST 
Created attachment 326887 [details]
Patch
Comment 3 Antoine Quint 2017-11-14 10:24:02 PST 
Comment on attachment 326887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326887&action=review

> Source/WebCore/html/OffscreenCanvas.cpp:71
> +    return { nullptr };

Shouldn't it be { }?

> Source/WebCore/html/OffscreenCanvas.h:71
> +    // FIXME: Should be optional<OffscreenRenderingContext> from above.

Is there a bug for this? Shouldn't we discard OffscreenRenderingContext until it's ready to use?
Comment 4 Dean Jackson 2017-11-14 13:11:47 PST 
Committed r224836: <https://trac.webkit.org/changeset/224836>
Comment 5 Ryan Haddad 2017-11-14 14:16:06 PST 
(In reply to Dean Jackson from comment #4)
> Committed r224836: <https://trac.webkit.org/changeset/224836>

This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/6034