Bug 179671 – Stub implementations of OffscreenCanvas getContext and transferToImageBitmap

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Dean Jackson]

Stub implementations of OffscreenCanvas getContext and transferToImageBitmap

[Radar WebKit Bug Importer]

<rdar://problem/35534018>

[Dean Jackson]

Created attachment 326887 [details]
Patch

[Antoine Quint]

Comment on attachment 326887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326887&action=review

> Source/WebCore/html/OffscreenCanvas.cpp:71
> +    return { nullptr };

Shouldn't it be { }?

> Source/WebCore/html/OffscreenCanvas.h:71
> +    // FIXME: Should be optional<OffscreenRenderingContext> from above.

Is there a bug for this? Shouldn't we discard OffscreenRenderingContext until it's ready to use?

[Dean Jackson]

Committed r224836: <https://trac.webkit.org/changeset/224836>

[Ryan Haddad]

(In reply to Dean Jackson from comment #4)
> Committed r224836: <https://trac.webkit.org/changeset/224836>

This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/6034