Bug 179670 - HaveInternalSDK includes should be "#include?"
Summary: HaveInternalSDK includes should be "#include?"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-14 09:47 PST by Keith Miller
Modified: 2018-01-27 09:51 PST (History)
10 users (show)

See Also:

Attachments
Patch (32.40 KB, patch)
2017-11-14 09:54 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (11.48 KB, patch)
2018-01-19 09:39 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-11-14 09:47:00 PST 
HaveInternalSDK includes should be "#include?"
Comment 1 Keith Miller 2017-11-14 09:54:54 PST 
Created attachment 326886 [details]
Patch
Comment 2 Build Bot 2017-11-14 09:57:04 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 mitz 2017-11-14 10:26:52 PST 
Comment on attachment 326886 [details]
Patch

This syntax isn’t supported by all Xcode version used to build WebKit.
Comment 4 Keith Miller 2017-11-14 10:30:11 PST 
Indeed, it looks like this won't work with Xcode 7. Closing.
Comment 5 Keith Miller 2018-01-19 09:30:37 PST 
Looks like we dropped support for Xcode 7 recently. Reopening this for review.
Comment 6 Keith Miller 2018-01-19 09:31:27 PST 
rdar://problem/35298458
Comment 7 mitz 2018-01-19 09:35:30 PST 
Comment on attachment 326886 [details]
Patch

r=me on the .xcconfig changes, but the bmalloc project change seems unrelated
Comment 8 Keith Miller 2018-01-19 09:36:53 PST 
(In reply to mitz from comment #7)
> Comment on attachment 326886 [details]
> Patch
> 
> r=me on the .xcconfig changes, but the bmalloc project change seems unrelated

Oh, weird. I think that's an automatic sorting this that webkit-patch does now... I'll revert it.
Comment 9 Keith Miller 2018-01-19 09:39:48 PST 
Created attachment 331744 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-01-19 10:33:25 PST 
The commit-queue encountered the following flaky tests while processing attachment 331744 [details]:

imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html bug 181565 (authors: cdumez@apple.com and jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2018-01-19 10:33:57 PST 
Comment on attachment 331744 [details]
Patch for landing

Clearing flags on attachment: 331744

Committed r227215: <https://trac.webkit.org/changeset/227215>
Comment 12 WebKit Commit Bot 2018-01-19 10:33:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 mitz 2018-01-27 09:51:13 PST 
(In reply to WebKit Commit Bot from comment #11)
> Comment on attachment 331744 [details]
> Patch for landing
> 
> Clearing flags on attachment: 331744
> 
> Committed r227215: <https://trac.webkit.org/changeset/227215>

More in <https://trac.webkit.org/r227715>.