Bug 179666 - REGRESSION (Safari 11): Buttons inside a fieldset legend cannot be clicked on in Safari 11
Summary: REGRESSION (Safari 11): Buttons inside a fieldset legend cannot be clicked on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari 11
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-14 05:59 PST by Dhaya
Modified: 2018-01-22 12:08 PST (History)
8 users (show)

See Also:


Attachments
Fieldset box model (23.07 KB, image/png)
2017-11-21 15:17 PST, Dragan
no flags Details
patch (5.92 KB, patch)
2018-01-21 03:07 PST, Antti Koivisto
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.12 MB, application/zip)
2018-01-21 06:37 PST, EWS Watchlist
no flags Details
patch (6.57 KB, patch)
2018-01-21 10:14 PST, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (6.52 KB, patch)
2018-01-22 09:43 PST, Antti Koivisto
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dhaya 2017-11-14 05:59:02 PST
In Safari 11 (macOS + iOS) and Safari TP Release 43, buttons and form inputs cannot be clicked on when located inside a fieldset legend, if the fieldset has the overflow style property set to hidden.
This issue doesn't occur in Safari 10, and other browsers.

Here is a minimal reproducible example: http://output.jsbin.com/yixeboj/2.
Comment 1 Radar WebKit Bug Importer 2017-11-14 10:04:35 PST
<rdar://problem/35534292>
Comment 2 Dragan 2017-11-21 15:17:59 PST
Created attachment 327433 [details]
Fieldset box model

Legend is inside strange part of fieldset box-model.
Comment 3 Antti Koivisto 2018-01-21 03:07:02 PST
Created attachment 331865 [details]
patch
Comment 4 EWS Watchlist 2018-01-21 06:37:03 PST
Comment on attachment 331865 [details]
patch

Attachment 331865 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6158154

New failing tests:
fast/forms/legend-overflow-hidden-hit-test.html
Comment 5 EWS Watchlist 2018-01-21 06:37:05 PST
Created attachment 331868 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 6 Antti Koivisto 2018-01-21 10:14:57 PST
Created attachment 331873 [details]
patch
Comment 7 zalan 2018-01-22 08:50:33 PST
Comment on attachment 331873 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331873&action=review

> Source/WebCore/rendering/RenderBlock.h:239
> +    bool hitTestExcludedChildrenInBorder(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);

private pls
Comment 8 Antti Koivisto 2018-01-22 09:43:10 PST
Created attachment 331937 [details]
patch
Comment 9 WebKit Commit Bot 2018-01-22 09:58:47 PST
Comment on attachment 331937 [details]
patch

Rejecting attachment 331937 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 331937, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/6170904
Comment 10 WebKit Commit Bot 2018-01-22 10:51:14 PST
Comment on attachment 331937 [details]
patch

Rejecting attachment 331937 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 331937, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/6171564
Comment 11 WebKit Commit Bot 2018-01-22 12:01:37 PST
Comment on attachment 331937 [details]
patch

Rejecting attachment 331937 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 331937, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/6172172
Comment 12 Antti Koivisto 2018-01-22 12:08:08 PST
https://trac.webkit.org/r227346