Bug 179666 – REGRESSION (Safari 11): Buttons inside a fieldset legend cannot be clicked on in Safari 11

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dhaya]

In Safari 11 (macOS + iOS) and Safari TP Release 43, buttons and form inputs cannot be clicked on when located inside a fieldset legend, if the fieldset has the overflow style property set to hidden.
This issue doesn't occur in Safari 10, and other browsers.

Here is a minimal reproducible example: http://output.jsbin.com/yixeboj/2.

[Radar WebKit Bug Importer]

<rdar://problem/35534292>

[Dragan]

Created attachment 327433 [details]
Fieldset box model

Legend is inside strange part of fieldset box-model.

[Antti Koivisto]

Created attachment 331865 [details]
patch

[EWS Watchlist]

Comment on attachment 331865 [details]
patch

Attachment 331865 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6158154

New failing tests:
fast/forms/legend-overflow-hidden-hit-test.html

[EWS Watchlist]

Created attachment 331868 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Antti Koivisto]

Created attachment 331873 [details]
patch

[zalan]

Comment on attachment 331873 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331873&action=review

> Source/WebCore/rendering/RenderBlock.h:239
> +    bool hitTestExcludedChildrenInBorder(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);

private pls

[Antti Koivisto]

Created attachment 331937 [details]
patch

[WebKit Commit Bot]

Comment on attachment 331937 [details]
patch

Rejecting attachment 331937 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 331937, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/6170904

[WebKit Commit Bot]

Comment on attachment 331937 [details]
patch

Rejecting attachment 331937 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 331937, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/6171564

[WebKit Commit Bot]

Comment on attachment 331937 [details]
patch

Rejecting attachment 331937 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 331937, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/6172172

[Antti Koivisto]

https://trac.webkit.org/r227346