Bug 179660 - [Cairo] Move native image drawing operation to CairoOperations
Summary: [Cairo] Move native image drawing operation to CairoOperations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-14 02:18 PST by Zan Dobersek
Modified: 2017-11-15 09:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (10.42 KB, patch)
2017-11-14 02:21 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (10.42 KB, patch)
2017-11-14 05:41 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-11-14 02:18:56 PST 
[Cairo] Move native image drawing operation to CairoOperations
Comment 1 Zan Dobersek 2017-11-14 02:21:20 PST 
Created attachment 326871 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-11-14 03:03:11 PST 
Comment on attachment 326871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326871&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:568
> +void drawNativeImage(PlatformContextCairo& platformContext, const NativeImagePtr& image, const FloatRect& destRect,
> +    const FloatRect& srcRect, CompositeOperator compositeOperator, BlendMode blendMode,
> +    ImageOrientation orientation, GraphicsContext& targetContext)

This should be a single line.
Comment 3 Zan Dobersek 2017-11-14 05:41:42 PST 
Created attachment 326874 [details]
Patch for landing
Comment 4 Zan Dobersek 2017-11-14 05:42:17 PST 
Comment on attachment 326874 [details]
Patch for landing

Clearing flags on attachment: 326874

Committed r224813: <https://trac.webkit.org/changeset/224813>
Comment 5 Zan Dobersek 2017-11-14 05:42:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2017-11-14 15:40:26 PST 
Committed r224854: <https://trac.webkit.org/changeset/224854>
Comment 7 Michael Catanzaro 2017-11-14 15:42:51 PST 
Committed r224855: <https://trac.webkit.org/changeset/224855>
Comment 8 Michael Catanzaro 2017-11-14 16:12:15 PST 
Committed r224859: <https://trac.webkit.org/changeset/224859>
Comment 9 Radar WebKit Bug Importer 2017-11-15 09:32:20 PST 
<rdar://problem/35561894>