RESOLVED FIXED 179660
[Cairo] Move native image drawing operation to CairoOperations 
https://bugs.webkit.org/show_bug.cgi?id=179660
Summary [Cairo] Move native image drawing operation to CairoOperations
Zan Dobersek
Reported 2017-11-14 02:18:56 PST
[Cairo] Move native image drawing operation to CairoOperations
Attachments
Patch (10.42 KB, patch)
2017-11-14 02:21 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.42 KB, patch)
2017-11-14 05:41 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-11-14 02:21:20 PST
Created attachment 326871 [details] Patch
Carlos Garcia Campos
Comment 2 2017-11-14 03:03:11 PST
Comment on attachment 326871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326871&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:568 > +void drawNativeImage(PlatformContextCairo& platformContext, const NativeImagePtr& image, const FloatRect& destRect, > + const FloatRect& srcRect, CompositeOperator compositeOperator, BlendMode blendMode, > + ImageOrientation orientation, GraphicsContext& targetContext) This should be a single line.
Zan Dobersek
Comment 3 2017-11-14 05:41:42 PST
Created attachment 326874 [details] Patch for landing
Zan Dobersek
Comment 4 2017-11-14 05:42:17 PST
Comment on attachment 326874 [details] Patch for landing Clearing flags on attachment: 326874 Committed r224813: <https://trac.webkit.org/changeset/224813>
Zan Dobersek
Comment 5 2017-11-14 05:42:21 PST
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 6 2017-11-14 15:40:26 PST
Committed r224854: <https://trac.webkit.org/changeset/224854>
Michael Catanzaro
Comment 7 2017-11-14 15:42:51 PST
Committed r224855: <https://trac.webkit.org/changeset/224855>
Michael Catanzaro
Comment 8 2017-11-14 16:12:15 PST
Committed r224859: <https://trac.webkit.org/changeset/224859>
Radar WebKit Bug Importer
Comment 9 2017-11-15 09:32:20 PST
<rdar://problem/35561894>
Note You need to log in before you can comment on or make changes to this bug.