Bug 179649 – Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers so that the WebProcesses can correctly construct ServiceWorker objects, with the right attributes / state.

[Chris Dumez]

Created attachment 326840 [details]
Patch

[Chris Dumez]

Created attachment 326844 [details]
Patch

[Brady Eidson]

Comment on attachment 326844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review

> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
> +    return {
> +        identifier,
> +        scriptURL.isolatedCopy(),
> +        state,
> +        type
> +    };

We don't normally multi-line something like this.

[Chris Dumez]

Comment on attachment 326844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review

>> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
>> +    };
> 
> We don't normally multi-line something like this.

I followed your pattern in ServiceWorkerRegistrationData :P

[Brady Eidson]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 326844 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326844&action=review
> 
> >> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
> >> +    };
> > 
> > We don't normally multi-line something like this.
> 
> I followed your pattern in ServiceWorkerRegistrationData :P

I think I multilined that because it was so many more thingies.

But probably shouldn't have. :)

[WebKit Commit Bot]

Comment on attachment 326844 [details]
Patch

Clearing flags on attachment: 326844

Committed r224804: <https://trac.webkit.org/changeset/224804>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35561904>